Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 6873014: Clear RenderThread of any Chrome specific code, and move a bunch of stuff out of RenderView. (Closed)

Created:
9 years, 8 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
tburkard
CC:
chromium-reviews, Erik does not do reviews, Aaron Boodman, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Clear RenderThread of any Chrome specific code, and move a bunch of stuff out of RenderView. Took out CookieMessageFilter since it's not used anymore. Removed RenderProcessTest and RendererMainTest since they really weren't testing much. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81851

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+835 lines, -1411 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 9 chunks +0 lines, -22 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 14 chunks +0 lines, -76 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 9 chunks +35 lines, -2 lines 0 comments Download
D chrome/renderer/chrome_render_observer.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/renderer/chrome_render_observer.cc View 1 1 chunk +0 lines, -346 lines 0 comments Download
A chrome/renderer/chrome_render_process_observer.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/renderer/chrome_render_process_observer.cc View 1 2 3 4 1 chunk +240 lines, -0 lines 0 comments Download
A + chrome/renderer/chrome_render_view_observer.h View 5 chunks +12 lines, -9 lines 0 comments Download
A + chrome/renderer/chrome_render_view_observer.cc View 9 chunks +36 lines, -21 lines 0 comments Download
M chrome/renderer/extensions/chrome_app_bindings.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.h View 1 2 chunks +45 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 4 chunks +193 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_process_bindings.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/renderer/renderer_main_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -126 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 1 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M content/browser/plugin_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/content_switches.h View 1 2 3 4 5 5 chunks +21 lines, -0 lines 0 comments Download
M content/common/content_switches.cc View 1 2 3 4 5 10 chunks +75 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/content_renderer_client.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/content_renderer_client.cc View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
D content/renderer/cookie_message_filter.h View 1 2 3 4 1 chunk +0 lines, -30 lines 0 comments Download
D content/renderer/cookie_message_filter.cc View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
M content/renderer/notification_provider.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 2 3 4 4 chunks +5 lines, -87 lines 0 comments Download
M content/renderer/render_process_observer.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_process_observer.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
D content/renderer/render_process_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -57 lines 0 comments Download
M content/renderer/render_thread.h View 1 2 3 4 7 chunks +0 lines, -26 lines 0 comments Download
M content/renderer/render_thread.cc View 1 2 3 4 5 17 chunks +9 lines, -182 lines 0 comments Download
M content/renderer/render_view.h View 1 9 chunks +12 lines, -48 lines 0 comments Download
M content/renderer/render_view.cc View 1 15 chunks +16 lines, -227 lines 0 comments Download
M content/renderer/render_view_observer.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_webapplicationcachehost_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_webidbfactory_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitclient_impl.cc View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/renderer_webstoragenamespace_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 8 months ago (2011-04-15 20:55:57 UTC) #1
tburkard
9 years, 8 months ago (2011-04-16 02:05:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698