Rename Instance_Trusted to Instance_Private, wire it up in Chrome.

Rename Instance_Trusted to Instance_Private, wire it up in Chrome.

Add C++ InstancePrivate.

BUG=None
TEST=PPAPI tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82104

[dmichael (off chromium), 2011-04-18 18:58:16]

I left the tests still using 'pp::Instance' for now, since all current plugins
rely on it.  After this lands successfully, I want to slap together a change to
make the tests use InstancePrivate.  I didn't think it was worth the work to
have two parallel sets of tests...  but if you think we should, I can do that.

http://codereview.chromium.org/6871040/diff/5003/ppapi/cpp/private/var_private.h
File ppapi/cpp/private/var_private.h (right):

http://codereview.chromium.org/6871040/diff/5003/ppapi/cpp/private/var_privat...
ppapi/cpp/private/var_private.h:28: VarPrivate(InstancePrivate* instance,
deprecated::ScriptableObject* object);
Note that this could just as easily use Instance, but I thought it wise to force
users of VarPrivate to use InstancePrivate.

http://codereview.chromium.org/6871040/diff/5003/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/6871040/diff/5003/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:969: plugin_private_interface_ =
reinterpret_cast<const PPP_Instance_Private*>(
Note I very nearly used static_cast, but went for consistency instead.  I tend
to prefer static_cast wherever possible, but in this case either should work
fine.  Let me know if you want me to change them all.

[brettw, 2011-04-18 21:13:26]

LGTM

http://codereview.chromium.org/6871040/diff/5003/ppapi/cpp/private/instance_p...
File ppapi/cpp/private/instance_private.cc (right):

http://codereview.chromium.org/6871040/diff/5003/ppapi/cpp/private/instance_p...
ppapi/cpp/private/instance_private.cc:50:
get_interface<PPB_Instance_Private>()->GetWindowObject(
I'd indent these lines to 4 spaces from the left of the "return" (same below).

http://codereview.chromium.org/6871040/diff/5003/webkit/plugins/ppapi/ppapi_p...
File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right):

http://codereview.chromium.org/6871040/diff/5003/webkit/plugins/ppapi/ppapi_p...
webkit/plugins/ppapi/ppapi_plugin_instance.cc:969: plugin_private_interface_ =
reinterpret_cast<const PPP_Instance_Private*>(
static_cast is better. Most of the reinterpret casts are because I always forget
you can static cast from void*. If you want, you can do a search and replace in
this file, but don't go too nuts trying to fix all of them.

[commit-bot: I haz the power, 2011-04-18 22:17:55]

Can't process patch for file ppapi/c/private/ppp_instance_private.h.
A +