Added functionality to use "SaveAs..." from PDF plugin.

Added functionality to use "SaveAs..." from PDF plugin.
It is exactly the same experience as user right-click and
select "SaveAs..." from pop-up menu. No disk access allowed for plugin.

DIscussed it with Chris Evans and he is ok with this solution from the security stand point.

Also added PDF resources for new UI.

BUG=56072, 75235
TEST=none, will send PDF cl separately.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81822

[jam, 2011-04-15 17:58:44]

http://codereview.chromium.org/6871020/diff/1/content/browser/tab_contents/ta...
File content/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/6871020/diff/1/content/browser/tab_contents/ta...
content/browser/tab_contents/tab_contents.cc:57: #include
"chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
TabContents doesn't know about TabContentsWrapper, so the IPC message shouldn't
be handled here.  We're trying to to remove all the "chrome/" includes from the
content module.

You should make DownloadTabHelper be a TabContentsObserver, that way it can have
an OnMessageReceived function that allows it to filer IPCs, and handle that new
message there.

[gene, 2011-04-15 18:33:54]

Done. Please take a look.
Thanks for the tip. I like it more this way.

On 2011/04/15 17:58:44, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/6871020/diff/1/content/browser/tab_contents/ta...
> File content/browser/tab_contents/tab_contents.cc (right):
> 
>
http://codereview.chromium.org/6871020/diff/1/content/browser/tab_contents/ta...
> content/browser/tab_contents/tab_contents.cc:57: #include
> "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
> TabContents doesn't know about TabContentsWrapper, so the IPC message
shouldn't
> be handled here.  We're trying to to remove all the "chrome/" includes from
the
> content module.
> 
> You should make DownloadTabHelper be a TabContentsObserver, that way it can
have
> an OnMessageReceived function that allows it to filer IPCs, and handle that
new
> message there.

[jam, 2011-04-15 18:53:22]

lgtm with the nit

http://codereview.chromium.org/6871020/diff/2006/chrome/browser/ui/download/d...
File chrome/browser/ui/download/download_tab_helper.cc (right):

http://codereview.chromium.org/6871020/diff/2006/chrome/browser/ui/download/d...
chrome/browser/ui/download/download_tab_helper.cc:11: #include
"content/common/view_messages.h"
you only need one of these message headers

http://codereview.chromium.org/6871020/diff/2006/chrome/common/render_messages.h
File chrome/common/render_messages.h (right):

http://codereview.chromium.org/6871020/diff/2006/chrome/common/render_message...
chrome/common/render_messages.h:492: IPC_MESSAGE_ROUTED0(ViewHostMsg_SaveAs)
I just realized that this needs to go into view_messages.h, since it's sent from
code in content.

[cevans, 2011-04-16 01:53:03]

Just wanted to raise a minor security issue (which we covered over chat).

What if the URL is evil.com/pdf.exe ?
We'll happily render a PDF from such an URL, as long as evil.com serves us a
PDF MIME type in the HTTP response.
The risk is that the attacker constructs a PDF that also parses as an EXE
(or some other combination, such as a PDF that also parses as a JAR or other
dangerous file type).

Since the PDF itself can initiate the "Save As" dialog, we should try and
avoid popping up a dialog that will save a dangerous file type with the
matching dangerous file extension. After all, the user things they are
simply saving a PDF.

The simplest solution is to make sure the saved PDF file actually ends in
.pdf


Cheers
Chris

On Fri, Apr 15, 2011 at 11:53 AM, <jam@chromium.org> wrote:

> lgtm with the nit
>
>
>
>
http://codereview.chromium.org/6871020/diff/2006/chrome/browser/ui/download/d...
> File chrome/browser/ui/download/download_tab_helper.cc (right):
>
>
>
http://codereview.chromium.org/6871020/diff/2006/chrome/browser/ui/download/d...
> chrome/browser/ui/download/download_tab_helper.cc:11: #include
> "content/common/view_messages.h"
> you only need one of these message headers
>
>
>
http://codereview.chromium.org/6871020/diff/2006/chrome/common/render_messages.h
> File chrome/common/render_messages.h (right):
>
>
>
http://codereview.chromium.org/6871020/diff/2006/chrome/common/render_message...
> chrome/common/render_messages.h:492:
>
> IPC_MESSAGE_ROUTED0(ViewHostMsg_SaveAs)
> I just realized that this needs to go into view_messages.h, since it's
> sent from code in content.
>
>
> http://codereview.chromium.org/6871020/
>