chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js - Issue 6871019: Enable (optional) blocking of webrequests in case a PAC script cannot be fetched or is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

Issue 6871019: Enable (optional) blocking of webrequests in case a PAC script cannot be fetched or is invalid. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/extensions/proxy_configuration.zip ('k') | chrome/common/extensions/docs/experimental.proxy.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

diff --git a/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js b/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

index 6b4fc09c4035e8d2553805d3ad84d2f1e46835bd..796d7b091efafcaafbe43532593185076c02a5d7 100644

--- a/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

+++ b/chrome/common/extensions/docs/examples/extensions/proxy_configuration/proxy_form_controller.js

@@ -590,9 +590,11 @@ ProxyFormController.prototype = {

var pacScriptURL = this.pacURL;

var pacManual = this.manualPac;

if (pacScriptURL)

- return {mode: 'pac_script', pacScript: {url: pacScriptURL}};

+ return {mode: 'pac_script',

+ pacScript: {url: pacScriptURL, mandatory: true}};

else if (pacManual)

- return {mode: 'pac_script', pacScript: {data: pacManual}};

+ return {mode: 'pac_script',

+ pacScript: {data: pacManual, mandatory: true}};

else

return {mode: 'auto_detect'};

case ProxyFormController.ProxyTypes.FIXED: