chrome/browser/net/pref_proxy_config_service_unittest.cc - Issue 6871019: Enable (optional) blocking of webrequests in case a PAC script cannot be fetched or is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/pref_proxy_config_service_unittest.cc

Issue 6871019: Enable (optional) blocking of webrequests in case a PAC script cannot be fetched or is invalid. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/net/pref_proxy_config_service_unittest.cc

diff --git a/chrome/browser/net/pref_proxy_config_service_unittest.cc b/chrome/browser/net/pref_proxy_config_service_unittest.cc

index 19bb53b630e72ca463d6c067bbfe9a3933efc15f..6d959a3878a2262e7f00e54278ca78b0318f28af 100644

--- a/chrome/browser/net/pref_proxy_config_service_unittest.cc

+++ b/chrome/browser/net/pref_proxy_config_service_unittest.cc

@@ -177,7 +177,7 @@ TEST_F(PrefProxyConfigServiceTest, Observers) {

CONFIG_VALID)).Times(1);

pref_service_->SetManagedPref(

prefs::kProxy,

- ProxyConfigDictionary::CreatePacScript(kFixedPacUrl));

+ ProxyConfigDictionary::CreatePacScript(kFixedPacUrl, false));

loop_.RunAllPending();

Mock::VerifyAndClearExpectations(&observer);

@@ -242,7 +242,7 @@ TEST_F(PrefProxyConfigServiceTest, Fallback) {