Enable (optional) blocking of webrequests in case a PAC script cannot be fetched or is invalid.

net/proxy/proxy_config.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_PROXY_PROXY_CONFIG_H_
 #define NET_PROXY_PROXY_CONFIG_H_
 #pragma once
 
 #include <string>
 
 #include "googleurl/src/gurl.h"
@@ skipping 129 matching lines @@
   }
 
   void set_pac_url(const GURL& url) {
     pac_url_ = url;
   }
 
   const GURL& pac_url() const {
     return pac_url_;
   }
 
+  void set_pac_mandatory(bool enable_pac_mandatory) {
+    pac_mandatory_ = enable_pac_mandatory;
+  }
+
+  bool pac_mandatory() const {
+    return pac_mandatory_;
+  }
+
   bool has_pac_url() const {
     return pac_url_.is_valid();
   }
 
   void set_auto_detect(bool enable_auto_detect) {
     auto_detect_ = enable_auto_detect;
   }
 
   bool auto_detect() const {
     return auto_detect_;
   }
 
   // Helpers to construct some common proxy configurations.
 
   static ProxyConfig CreateDirect() {
     return ProxyConfig();
   }
 
   static ProxyConfig CreateAutoDetect() {
     ProxyConfig config;
     config.set_auto_detect(true);
     return config;
   }
 
   static ProxyConfig CreateFromCustomPacURL(const GURL& pac_url) {
     ProxyConfig config;
     config.set_pac_url(pac_url);
+    // By default fall back to direct connection in case PAC script fails.
+    config.set_pac_mandatory(false);
     return config;
   }
 
  private:
   // True if the proxy configuration should be auto-detected.
   bool auto_detect_;
 
   // If non-empty, indicates the URL of the proxy auto-config file to use.
   GURL pac_url_;
 
+  // If true, blocks all traffic in case fetching the pac script from |pac_url_|
+  // fails. Only valid if pac_url_ is non-empty.

[eroman, 2011/05/03 09:45:24]

minor nit: enclose enclose "pac_url_" as in |pac_url_|, similar to above.

[battre, 2011/05/03 09:55:14]

Done.

+  bool pac_mandatory_;
+
   // Manual proxy settings.
   ProxyRules proxy_rules_;
 
   int id_;
 };
 
 }  // namespace net
 
 
 
 #endif  // NET_PROXY_PROXY_CONFIG_H_