Make RunHooks a method on ChangeList.

Make RunHooks a method on ChangeList.

BUG=none
TEST=watchlists work again.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81950

[commit-bot: I haz the power, 2011-04-15 16:05:28]

No comments yet.

[Bernhard Bauer, 2011-04-15 16:07:04]

Please review.

[M-A Ruel, 2011-04-18 14:43:11]

lgtm with style nits.

http://codereview.chromium.org/6871015/diff/1/git_cl.py
File git_cl.py (right):

http://codereview.chromium.org/6871015/diff/1/git_cl.py#newcode517
git_cl.py:517: if not root:
While at it;
  root = os.path.abspath(root or '.')

and remove lines 519-521 since line 520 can never trigger atm.

[Bernhard Bauer, 2011-04-18 14:50:36]

On 2011/04/18 14:43:11, Marc-Antoine Ruel wrote:
> lgtm with style nits.
> 
> http://codereview.chromium.org/6871015/diff/1/git_cl.py
> File git_cl.py (right):
> 
> http://codereview.chromium.org/6871015/diff/1/git_cl.py#newcode517
> git_cl.py:517: if not root:
> While at it;
>   root = os.path.abspath(root or '.')
> 
> and remove lines 519-521 since line 520 can never trigger atm.

Done. 

Could you run the presubmit checks? It seems to work locally for me, but git cl
presubmit is acting up again :-/

[M-A Ruel, 2011-04-18 15:06:30]

~/src/depot_tools> git cl presubmit
Current branch bauerb is up to date.
Loaded authentication cookies from /home/maruel/.codereview_upload_cookies
Traceback (most recent call last):
  File "/home/maruel/src/depot_tools/git_cl.py", line 1452, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/maruel/src/depot_tools/git_cl.py", line 1437, in main
    return command(parser, argv[1:])
  File "/home/maruel/src/depot_tools/git_cl.py", line 887, in CMDpresubmit
    tbr=False, may_prompt=False, verbose=options.verbose)
  File "/home/maruel/src/depot_tools/git_cl.py", line 536, in RunHook
    absroot,
NameError: global name 'absroot' is not defined

eh.

[Bernhard Bauer, 2011-04-18 15:35:45]

On 2011/04/18 15:06:30, Marc-Antoine Ruel wrote:
> ~/src/depot_tools> git cl presubmit
> Current branch bauerb is up to date.
> Loaded authentication cookies from /home/maruel/.codereview_upload_cookies
> Traceback (most recent call last):
>   File "/home/maruel/src/depot_tools/git_cl.py", line 1452, in <module>
>     sys.exit(main(sys.argv[1:]))
>   File "/home/maruel/src/depot_tools/git_cl.py", line 1437, in main
>     return command(parser, argv[1:])
>   File "/home/maruel/src/depot_tools/git_cl.py", line 887, in CMDpresubmit
>     tbr=False, may_prompt=False, verbose=options.verbose)
>   File "/home/maruel/src/depot_tools/git_cl.py", line 536, in RunHook
>     absroot,
> NameError: global name 'absroot' is not defined
> 
> eh.

Whoops. 

I named the second one absroot now.

[M-A Ruel, 2011-04-18 15:55:56]

~/src/depot_tools> git cl presubmit
Current branch bauerb is up to date.
Loaded authentication cookies from /home/maruel/.codereview_upload_cookies
Running presubmit commit checks ...
Syncing rietveld...
Running patch.sh
Running upload-local-tracking-branch.sh
Running tbr.sh
Running abandon.sh
Running basic.sh
Running hooks.sh
Running push-basic.sh
Running post-dcommit-hook-test.sh
Running submit-from-new-dir.sh
Running upstream.sh
Running upload-stale.sh
Running save-description-on-failure.sh

Presubmit checks took 138.3s to calculate.

Presubmit checks passed.

[Bernhard Bauer, 2011-04-18 15:57:40]

Yay, thanks!

On Mon, Apr 18, 2011 at 17:55,  <maruel@chromium.org> wrote:
>  ~/src/depot_tools> git cl presubmit
> Current branch bauerb is up to date.
> Loaded authentication cookies from /home/maruel/.codereview_upload_cookies
> Running presubmit commit checks ...
> Syncing rietveld...
> Running patch.sh
> Running upload-local-tracking-branch.sh
> Running tbr.sh
> Running abandon.sh
> Running basic.sh
> Running hooks.sh
> Running push-basic.sh
> Running post-dcommit-hook-test.sh
> Running submit-from-new-dir.sh
> Running upstream.sh
> Running upload-stale.sh
> Running save-description-on-failure.sh
>
> Presubmit checks took 138.3s to calculate.
>
> Presubmit checks passed.
>
>
> http://codereview.chromium.org/6871015/
>