chrome/browser/chromeos/login/wizard_in_process_browser_test.cc - Issue 6870016: Refcount browser process in BaseLoginDisplayHost so message loop does not exit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_in_process_browser_test.cc

Issue 6870016: Refcount browser process in BaseLoginDisplayHost so message loop does not exit (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Delete LoginDisplayHost in MessageLoop::Run() context in test framework. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/login/wizard_in_process_browser_test.cc

diff --git a/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc b/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc

index f203df909310a163b2d87a4925e82856ec661d54..49d38f85d70c8e144047b6e40a720822b24fc356 100644

--- a/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc

+++ b/chrome/browser/chromeos/login/wizard_in_process_browser_test.cc

@@ -34,7 +34,7 @@ Browser* WizardInProcessBrowserTest::CreateBrowser(Profile* profile) {

void WizardInProcessBrowserTest::CleanUpOnMainThread() {

// LoginDisplayHost owns controllers and all windows.

- delete host_;

+ MessageLoopForUI::current()->DeleteSoon(FROM_HERE,host_);

// Observers and what not are notified after the views are deleted, which

// happens after a delay (because they are contained in a WidgetGtk which

« no previous file with comments | « chrome/browser/chromeos/login/base_login_display_host.cc ('k') | no next file » | no next file with comments »