Issue 6870010: Disabling realtimecomm_GTalkPlayground (in HWQual).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6870010: Disabling realtimecomm_GTalkPlayground (in HWQual). (Closed)

Created:
9 years, 8 months ago by noahric

Modified:
9 years, 7 months ago

Reviewers:
zhurunz1, DaleCurtis

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Disabling realtimecomm_GTalkPlayground (in HWQual). A test issue is keeping this from passing, tracking by crosbug.com/3001. Change-Id: Icfd6524cf4e8247d2b8320e9f02a3944cd064e3f BUG=chromium-os:3001 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1d81fa8

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	client/site_tests/suite_HWQual/control.auto	View		1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

9 years, 8 months ago (2011-04-15 17:16:14 UTC) #2

LGTM

On Fri, Apr 15, 2011 at 9:57 AM, <noahric@chromium.org> wrote:

> Reviewers: zhurunz1, dalec,
>
> Description:
> Disabling realtimecomm_GTalkPlayground (in HWQual).
>
> A test issue is keeping this from passing, tracking by crosbug.com/3001.
>
> Change-Id: Icfd6524cf4e8247d2b8320e9f02a3944cd064e3f
>
> BUG=chromium-os:3001
> TEST=
>
>
> Please review this at http://codereview.chromium.org/6870010/
>
> SVN Base: ssh://gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M client/site_tests/suite_HWQual/control.auto
>
>
> Index: client/site_tests/suite_HWQual/control.auto
> diff --git a/client/site_tests/suite_HWQual/control.auto
> b/client/site_tests/suite_HWQual/control.auto
> index
>
0c2cbf46120214b7c45da75d4768c98cf19fa563..e6443fd8dc7969c7b9da759f79de0111360fa0cb
> 100644
> --- a/client/site_tests/suite_HWQual/control.auto
> +++ b/client/site_tests/suite_HWQual/control.auto
> @@ -81,13 +81,17 @@ job.run_test('audiovideo_FFMPEG',
>  job.run_test('audiovideo_V4L2')
>
>  # RealTimeComm
> +# TODO(noahric): crosbug.com/3001 - Test issue is causing this test
> +# to fail.
> +#
>  # TODO(zhurunz): crosbug.com/p/1332 - improve performance and
>  # replace with fps_gtalk_down >= 28.0 and fps_gtalk_dup >= 29.5.
> -job.run_test('realtimecomm_GTalkPlayground',
> -             constraints=[
> -                 'fps_gtalk_down >= 20.0',
> -                 'fps_gtalk_up >= 20.0',
> -             ])
> +#
> +# job.run_test('realtimecomm_GTalkPlayground',
> +#              constraints=[
> +#                  'fps_gtalk_down >= 20.0',
> +#                  'fps_gtalk_up >= 20.0',
> +#              ])
>  job.run_test('realtimecomm_GTalkAudioPlayground',
>              constraints=['ctime_gtalk + stime_gtalk < 30'])
>  job.run_test('realtimecomm_GTalkLmiCamera',
>
>
>

Expand Messages | Collapse Messages