Usability improvements to about:gpu status

chrome/browser/resources/gpu_internals/info_view.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview This view displays information on the current GPU
  * hardware.  Its primary usefulness is to allow users to copy-paste
  * their data in an easy to read format for bug reports.
  */
@@ skipping 41 matching lines @@
           },
           {
             description: 'Software rendering list version',
             value: clientInfo.blacklist_version
           }]);
       } else {
         this.setText_('client-info', '... loading...');
       }
 
       // Feature map
-      var featureNameMap = {
-        'accelerated_2d_canvas': 'Canvas',
-        'accelerated_compositing': '3D CSS',
+      var featureLabelMap = {
+        '2d_canvas': 'Canvas',
+        '3d_css': '3D CSS',
+        'compositing': 'Compositing',
         'webgl': 'WebGL',
         'multisampling': 'WebGL multisampling'
       };
+      var statusLabelMap = {
+        'disabled_software': 'Software only. Hardware acceleration disabled.',
+        'disabled_off': 'Unavailable. Hardware acceleration disabled.',
+        'software': 'Software rendered. Hardware acceleration not enabled.',
+        'unavailable_off': 'Unavailable. Hardware acceleration unavailable',
+        'unavailable_software':
+            'Software only, hardware acceleration unavailable',
+        'enabled': 'Hardware accelerated'
+      };
+      var statusClassMap = {
+        'disabled_software': 'feature-yellow',
+        'disabled_off': 'feature-red',
+        'software': 'feature-yellow',
+        'unavailable_off': 'feature-red',
+        'unavailable_software': 'feature-yellow',
+        'enabled': 'feature-green'
+      };
 
       // GPU info, basic
       var diagnostics = this.querySelector('.diagnostics');
       var featureStatusList = this.querySelector('.feature-status-list');
       var problemsDiv = this.querySelector('.problems-div');
       var problemsList = this.querySelector('.problems-list');
       var gpuInfo = browserBridge.gpuInfo;
       var i;
       if (gpuInfo) {
         // Not using jstemplate here for blacklist status because we construct
         // href from data, which jstemplate can't seem to do.
         if (gpuInfo.featureStatus) {
           // feature status list
           featureStatusList.textContent = '';
           for (i = 0; i < gpuInfo.featureStatus.featureStatus.length;
                i++) {
             var feature = gpuInfo.featureStatus.featureStatus[i];
             var featureEl = document.createElement('li');
 
             var nameEl = document.createElement('span');
-            nameEl.textContent = featureNameMap[feature.name] + ': ';
+            if (!featureLabelMap[feature.name])
+              console.log('Missing featureLabel for', feature.name);
+            nameEl.textContent = featureLabelMap[feature.name] + ': ';
             featureEl.appendChild(nameEl);
 
             var statusEl = document.createElement('span');
-            if (feature.status == 'enabled') {
-              statusEl.textContent = 'enabled';
-              statusEl.className = 'feature-enabled';
-            } else if (feature.status == 'software') {
-              statusEl.textContent = 'software only';
-              statusEl.className = 'feature-software';
-            } else if (feature.status == 'unavailable') {
-              statusEl.textContent = 'unavailable';
-              statusEl.className = 'feature-disabled';
-            } else { // disabled
-              statusEl.textContent = 'disabled';
-              statusEl.className = 'feature-disabled';
-            }
+            if (!statusLabelMap[feature.status])
+              console.log('Missing statusLabel for', feature.status);
+            if (!statusClassMap[feature.status])
+              console.log('Missing statusClass for', feature.status);
+            statusEl.textContent = statusLabelMap[feature.status];
+            statusEl.className = statusClassMap[feature.status];
             featureEl.appendChild(statusEl);
 
             featureStatusList.appendChild(featureEl);
           }
 
           // problems list
           if (gpuInfo.featureStatus.problems.length) {
             problemsDiv.hidden = false;
             problemsList.textContent = '';
             for (i = 0; i < gpuInfo.featureStatus.problems.length; i++) {
@@ skipping 102 matching lines @@
 
       peg.innerHTML = '';
       peg.appendChild(template);
     }
   };
 
   return {
     InfoView: InfoView
   };
 });