Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 6869043: Add command-line control of the HSTS preload list. (Closed)

Created:
9 years, 8 months ago by Chris Evans
Modified:
9 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., wtc
Visibility:
Public.

Description

Add command-line control of the HSTS preload list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82409

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -46 lines) Patch
M chrome/browser/transport_security_persister.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A net/base/net_switches.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A net/base/net_switches.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M net/base/transport_security_state.h View 1 3 chunks +9 lines, -2 lines 0 comments Download
M net/base/transport_security_state.cc View 1 2 14 chunks +57 lines, -30 lines 0 comments Download
M net/base/transport_security_state_unittest.cc View 1 7 chunks +26 lines, -13 lines 0 comments Download
M net/net.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Chris Evans
What do you think of this approach to adding command-line control to HSTS? If you ...
9 years, 8 months ago (2011-04-16 17:58:01 UTC) #1
abarth-chromium
You don't think the net-internals UI is better?
9 years, 8 months ago (2011-04-16 18:02:03 UTC) #2
cevans
On Sat, Apr 16, 2011 at 11:02 AM, <abarth@chromium.org> wrote: > You don't think the ...
9 years, 8 months ago (2011-04-17 05:17:55 UTC) #3
abarth-chromium
On Sat, Apr 16, 2011 at 10:17 PM, Chris Evans <cevans@google.com> wrote: > On Sat, ...
9 years, 8 months ago (2011-04-17 05:34:41 UTC) #4
abarth-chromium
No tests for the command line parsing? http://codereview.chromium.org/6869043/diff/1/net/base/transport_security_state.cc File net/base/transport_security_state.cc (right): http://codereview.chromium.org/6869043/diff/1/net/base/transport_security_state.cc#newcode341 net/base/transport_security_state.cc:341: base::Base64Decode(hash.substr(5, hash.size() ...
9 years, 8 months ago (2011-04-17 05:39:23 UTC) #5
cevans
On Sat, Apr 16, 2011 at 10:34 PM, Adam Barth <abarth@chromium.org> wrote: > On Sat, ...
9 years, 8 months ago (2011-04-17 05:40:14 UTC) #6
cevans
On Sat, Apr 16, 2011 at 10:39 PM, <abarth@chromium.org> wrote: > No tests for the ...
9 years, 8 months ago (2011-04-17 05:44:18 UTC) #7
agl
I'm in committee all day so can't do a proper review until much later. I'm ...
9 years, 8 months ago (2011-04-18 13:54:46 UTC) #8
Chris Evans
Changes since last time: - Fix "empty domain string" UI bug + add test (this ...
9 years, 8 months ago (2011-04-20 02:53:24 UTC) #9
abarth-chromium
http://codereview.chromium.org/6869043/diff/12001/net/base/net_switches.cc File net/base/net_switches.cc (right): http://codereview.chromium.org/6869043/diff/12001/net/base/net_switches.cc#newcode12 net/base/net_switches.cc:12: // point will be hit. What?
9 years, 8 months ago (2011-04-20 04:49:32 UTC) #10
Chris Evans
On 2011/04/20 04:49:32, abarth wrote: > http://codereview.chromium.org/6869043/diff/12001/net/base/net_switches.cc > File net/base/net_switches.cc (right): > > http://codereview.chromium.org/6869043/diff/12001/net/base/net_switches.cc#newcode12 > ...
9 years, 8 months ago (2011-04-20 04:55:07 UTC) #11
agl
LGTM
9 years, 8 months ago (2011-04-20 13:24:48 UTC) #12
eroman
Please move this command line out of net/ and into chrome/ (chrome/common/chrome_switches.cc). We do all ...
9 years, 7 months ago (2011-04-29 23:58:34 UTC) #13
cevans
Thanks. http://code.google.com/p/chromium/issues/detail?id=81042 and I ReleaseBlock'ed it so it doesn't fester. I'll clarify exactly what we ...
9 years, 7 months ago (2011-04-30 00:45:45 UTC) #14
eroman
9 years, 7 months ago (2011-04-30 01:03:18 UTC) #15
Thanks Chris!

Powered by Google App Engine
This is Rietveld 408576698