Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark

base/metrics/histogram.cc

Index: base/metrics/histogram.cc
===================================================================
--- base/metrics/histogram.cc	(revision 81725)
+++ base/metrics/histogram.cc	(working copy)
@@ -14,6 +14,7 @@
 #include <algorithm>
 #include <string>
 
+#include "base/debug/leak_annotations.h"
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "base/stringprintf.h"
@@ -101,6 +102,7 @@
 
   DCHECK_EQ(HISTOGRAM, histogram->histogram_type());
   DCHECK(histogram->HasConstructorArguments(minimum, maximum, bucket_count));
+  ANNOTATE_LEAKING_OBJECT_PTR(histogram);  // see crbug.com/79322

[jar (doing other things), 2011/04/15 15:53:37]

There are actually 3 distinct FactoryGet routines in this file (each handling a
slightly different set of argument lists).  Each has this same pattern, and each
should probably be annotated this way.  

I tried to find a way to factor out the common code patterns (I hate
replication), but did not see a clean and readable way... but if you see a
way... great.

[Alexander Potapenko, 2011/04/18 09:45:13]

There are actually four of them, as I can see:

Histogram::FactoryGet
BooleanHistogram::FactoryGet
LinearHistogram::FactoryGet
CustomHistogram::FactoryGet

I've annotated all of them -- is that ok?

   return histogram;
 }