Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: test/mjsunit/regexp-string-methods.js

Issue 6869007: Cleanup of mjsunit.js code and make assertEquals more strict. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed review comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/regexp-static.js ('k') | test/mjsunit/regress/regress-1199637.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10 matching lines...) Expand all
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Regexp shouldn't use String.prototype.slice() 28 // Regexp shouldn't use String.prototype.slice()
29 var s = new String("foo"); 29 var s = new String("foo");
30 assertEquals("f", s.slice(0,1)); 30 assertEquals("f", s.slice(0,1));
31 String.prototype.slice = function() { return "x"; } 31 String.prototype.slice = function() { return "x"; };
32 assertEquals("x", s.slice(0,1)); 32 assertEquals("x", s.slice(0,1));
33 assertEquals("g", /g/.exec("gg")); 33 assertEquals(["g"], /g/.exec("gg"));
34 34
35 // Regexp shouldn't use String.prototype.charAt() 35 // Regexp shouldn't use String.prototype.charAt()
36 var f1 = new RegExp("f", "i"); 36 var f1 = new RegExp("f", "i");
37 assertEquals("F", f1.exec("F")); 37 assertEquals(["F"], f1.exec("F"));
38 assertEquals("f", "foo".charAt(0)); 38 assertEquals("f", "foo".charAt(0));
39 String.prototype.charAt = function(idx) { return 'g'; }; 39 String.prototype.charAt = function(idx) { return 'g'; };
40 assertEquals("g", "foo".charAt(0)); 40 assertEquals("g", "foo".charAt(0));
41 var f2 = new RegExp("[g]", "i"); 41 var f2 = new RegExp("[g]", "i");
42 assertEquals("G", f2.exec("G")); 42 assertEquals(["G"], f2.exec("G"));
43 assertTrue(f2.ignoreCase); 43 assertTrue(f2.ignoreCase);
44 44
45 // On the other hand test is defined in a semi-coherent way as a call to exec. 45 // On the other hand test is defined in a semi-coherent way as a call to exec.
46 // 15.10.6.3 46 // 15.10.6.3
47 // We match other browsers in using the original value of RegExp.prototype.exec. 47 // We match other browsers in using the original value of RegExp.prototype.exec.
48 // I.e., RegExp.prototype.test shouldn't use the current value of 48 // I.e., RegExp.prototype.test shouldn't use the current value of
49 // RegExp.prototype.exec. 49 // RegExp.prototype.exec.
50 RegExp.prototype.exec = function(string) { return 'x'; } 50 RegExp.prototype.exec = function(string) { return 'x'; };
51 assertFalse(/f/.test('x')); 51 assertFalse(/f/.test('x'));
OLDNEW
« no previous file with comments | « test/mjsunit/regexp-static.js ('k') | test/mjsunit/regress/regress-1199637.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698