Issue 6865033: Made full tab file browser to open automatically when a new disk device is properly mounted.

Issue 6865033: Made full tab file browser to open automatically when a new disk device is properly mounted. (Closed)

Created:
9 years, 8 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
rginda, achuithb

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Made full tab file browser to open automatically when a new disk device is properly mounted. BUG=chromium-os:14215 TEST=plug in SD card or USB key, observe file browser opens and navigates to that new device Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81881

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -118 lines)			Patch
M	build/common.gypi	View	1 2 3 4	4 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
A	chrome/browser/extensions/file_manager_util.h	View	1 2 3	1 chunk	+50 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/file_manager_util.cc	View	1	1 chunk	+132 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/file_manager_dialogs.cc	View	1 2 3 4 5	6 chunks	+4 lines, -106 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

achuithb

http://codereview.chromium.org/6865033/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right): http://codereview.chromium.org/6865033/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc#newcode148 chrome/browser/chromeos/extensions/file_browser_event_router.cc:148: FileManagerDialog::ShowFullTabUrl(profile_, disk->mount_path()); How does this compile? You're not including ...

9 years, 8 months ago (2011-04-16 00:33:52 UTC) #3

zel

PTAL all outstanding issues should be fixes and I have also made new FB default ...

9 years, 8 months ago (2011-04-16 18:47:03 UTC) #4

rginda

9 years, 8 months ago (2011-04-16 19:19:48 UTC) #5

On 2011/04/16 18:47:03, zel wrote:
> PTAL
> 
> all outstanding issues should be fixes and I have also made new FB default on
> ChromeOS

LGTM

Expand Messages | Collapse Messages