Issue 6865013: Introduce experimental natives that are enabled by a runtime flag.

Issue 6865013: Introduce experimental natives that are enabled by a runtime flag. (Closed)

Created:
9 years, 8 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Introduce experimental natives that are enabled by a runtime flag. Clean up the use of js2c. We generated two identical files. R=sgjesse@chromium.org,rossberg@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7630

Patch Set 2 : Add missing file #

Patch Set 3 : Fix experimental extension build. #

Total comments: 4

Patch Set 4 : Address comments #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -30 lines)			Patch
M	src/SConscript	View		4 chunks	+15 lines, -3 lines	0 comments	Download
M	src/bootstrapper.cc	View		6 chunks	+26 lines, -1 line	0 comments	Download
M	src/d8.gyp	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	src/extensions/experimental/experimental.gyp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/natives.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
A	src/proxy.js	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		5 chunks	+24 lines, -2 lines	0 comments	Download
M	tools/js2c.py	View		4 chunks	+4 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6865013/diff/4002/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/6865013/diff/4002/src/bootstrapper.cc#newcode1642 src/bootstrapper.cc:1642: if (FLAG_harmony_proxies) { If we have more experimental ...

9 years, 8 months ago (2011-04-15 12:02:15 UTC) #2

Mads Ager (chromium)

9 years, 8 months ago (2011-04-15 12:30:12 UTC) #3

http://codereview.chromium.org/6865013/diff/4002/src/bootstrapper.cc
File src/bootstrapper.cc (right):

http://codereview.chromium.org/6865013/diff/4002/src/bootstrapper.cc#newcode1642
src/bootstrapper.cc:1642: if (FLAG_harmony_proxies) {
On 2011/04/15 12:02:15, Søren Gjesse wrote:
> If we have more experimental features enabled this way
> (FLAG_experimentl_feature_x as well) we will just find a way to pick the right
> files to compile instead of all of them - right?

Right, that is what I had in mind. You can get the name of the native from the
ExperimentalNatives collection and chose based on that.

http://codereview.chromium.org/6865013/diff/4002/src/d8.gyp
File src/d8.gyp (right):

http://codereview.chromium.org/6865013/diff/4002/src/d8.gyp#newcode63
src/d8.gyp:63: 'd8.js',
On 2011/04/15 12:02:15, Søren Gjesse wrote:
> Maybe add macros.py here for completeness.

Done.

Expand Messages | Collapse Messages