Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 6865011: Fix openssl build (Closed)

Created:
9 years, 8 months ago by joth
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix openssl build In follow up to http://codereview.chromium.org/6805019/ fixes a couple namespace issues. BUG=None TEST=Builds with use_openssl=1 set. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M crypto/openssl_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
joth
rvargas, agl - I'll need OWNERS approval for crypto/... please. Cheers
9 years, 8 months ago (2011-04-15 09:44:01 UTC) #1
agl
On Fri, Apr 15, 2011 at 5:44 AM, <joth@chromium.org> wrote: > Reviewers: bulach, rvargas, agl, ...
9 years, 8 months ago (2011-04-15 11:50:00 UTC) #2
commit-bot: I haz the power
Presubmit check for 6865011-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 8 months ago (2011-04-15 13:07:46 UTC) #3
joth
9 years, 8 months ago (2011-04-15 14:04:26 UTC) #4
On 15 April 2011 12:49, Adam Langley <agl@chromium.org> wrote:

> On Fri, Apr 15, 2011 at 5:44 AM,  <joth@chromium.org> wrote:
> > Reviewers: bulach, rvargas, agl,
> >
> > Message:
> > rvargas, agl - I'll need OWNERS approval for crypto/... please.
>
> LGTM. (I wouldn't worry too much about OWNERS for build fixes.)
>
> Ah good point. I hadn't spotted I can opt out of OWNERS check.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698