Chromium Code Reviews| Index: chrome/browser/extensions/extension_file_browser_private_api.cc |
| =================================================================== |
| --- chrome/browser/extensions/extension_file_browser_private_api.cc (revision 82172) |
| +++ chrome/browser/extensions/extension_file_browser_private_api.cc (working copy) |
| @@ -190,11 +190,14 @@ |
| DCHECK(function_); |
| } |
|
ericu
2011/04/20 02:23:46
This comment should have stayed.
zel
2011/04/20 02:49:57
Done.
|
| - // fileapi::FileSystemCallbackDispatcher overrides. |
| virtual void DidSucceed() OVERRIDE { |
| NOTREACHED(); |
| } |
| + virtual void DidGetLocalPath(const FilePath& local_path) { |
| + NOTREACHED(); |
| + } |
| + |
| virtual void DidReadMetadata(const base::PlatformFileInfo& info, |
| const FilePath& unused) OVERRIDE { |
| NOTREACHED(); |
| @@ -396,6 +399,10 @@ |
| NOTREACHED(); |
| } |
| + virtual void DidGetLocalPath(const FilePath& local_path) { |
| + NOTREACHED(); |
| + } |
| + |
| virtual void DidReadMetadata(const base::PlatformFileInfo& info, |
| const FilePath& unused) OVERRIDE { |
| NOTREACHED(); |
| @@ -477,11 +484,12 @@ |
| return false; |
| } |
| - FilePath root_path = path_manager->GetFileSystemRootPathOnFileThread( |
| - file_origin_url, |
| - fileapi::kFileSystemTypeExternal, |
| - virtual_path, |
| - false); // create |
| + FilePath root_path = |
| + path_manager->ValidateFileSystemRootAndGetPathOnFileThread( |
| + file_origin_url, |
| + fileapi::kFileSystemTypeExternal, |
| + virtual_path, |
| + false); // create |
| FilePath final_file_path = root_path.Append(virtual_path); |
| // Check if this file system entry exists first. |
| @@ -751,7 +759,7 @@ |
| NOTREACHED(); |
| continue; |
| } |
| - FilePath root = path_manager->GetFileSystemRootPathOnFileThread( |
| + FilePath root = path_manager->ValidateFileSystemRootAndGetPathOnFileThread( |
| origin_url, |
| fileapi::kFileSystemTypeExternal, |
| FilePath(virtual_path), |