base/native_library_mac.mm - Issue 6864020: linux: don't always print dlopen errors from LoadNativeLibrary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/native_library_mac.mm

Issue 6864020: linux: don't always print dlopen errors from LoadNativeLibrary (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/native_library_mac.mm

diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm

index 742d92a145def47917d5762ad6cd67437c961b53..cf75aa7f6bc46be2d039a967633e60cd00eb84d9 100644

--- a/base/native_library_mac.mm

+++ b/base/native_library_mac.mm

@@ -16,7 +16,8 @@

namespace base {

// static

-NativeLibrary LoadNativeLibrary(const FilePath& library_path) {

+NativeLibrary LoadNativeLibrary(const FilePath& library_path,

+ std::string* error) {

// dlopen() etc. open the file off disk.

if (library_path.Extension() == "dylib" ||

!file_util::DirectoryExists(library_path)) {