linux: don't always print dlopen errors from LoadNativeLibrary

base/native_library_win.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/native_library.h"
 
 #include <windows.h>
 
 #include "base/file_util.h"
 #include "base/threading/thread_restrictions.h"
@@ skipping 21 matching lines @@
   }
 
   HMODULE module = (*load_library_api)(library_path.value().c_str());
   if (restore_directory)
     file_util::SetCurrentDirectory(current_directory);
 
   return module;
 }
 
 // static
-NativeLibrary LoadNativeLibrary(const FilePath& library_path) {
+NativeLibrary LoadNativeLibrary(const FilePath& library_path,
+                                std::string* error) {
   return LoadNativeLibraryHelper(library_path, LoadLibraryW);

[awong, 2011/04/15 18:57:01]

If the return is NULL, populate with Populate with result of
FormatString(GetLastError()), or at least GetLastError()?

Maybe do this in the Helper function?

BTW, why in the world do we botther with a Helper function here?

[Evan Martin, 2011/04/15 19:00:04]

(Same argument here as for Mac.)
Probably to share code with LoadNativeLibraryDynamically.

[awong, 2011/04/15 19:03:56]

Oh duh.

 }
 
 NativeLibrary LoadNativeLibraryDynamically(const FilePath& library_path) {
   typedef HMODULE (WINAPI* LoadLibraryFunction)(const wchar_t* file_name);
 
   LoadLibraryFunction load_library;
   load_library = reinterpret_cast<LoadLibraryFunction>(
       GetProcAddress(GetModuleHandle(L"kernel32.dll"), "LoadLibraryW"));
 
   return LoadNativeLibraryHelper(library_path, load_library);
 }
 
 // static
 void UnloadNativeLibrary(NativeLibrary library) {
   FreeLibrary(library);
 }
 
 // static
 void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
                                           const char* name) {
   return GetProcAddress(library, name);
 }
 
 // static
 string16 GetNativeLibraryName(const string16& name) {
   return name + ASCIIToUTF16(".dll");
 }
 
 }  // namespace base