Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 6861001: first-run: Pull IsBrowserAlreadyRunning() out of upgrade_util_win.h. (Closed)

Created:
9 years, 8 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

first-run: Pull IsBrowserAlreadyRunning() out of upgrade_util_win.h. This concept is not specific to upgrade path and thus shouldn't belong there. Move it to a new header file called browser_util_win.h as it's more appropriate. BUG=79203 TEST=None R=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81691

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -28 lines) Patch
M chrome/browser/browser_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browser_main_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +2 lines, -1 line 0 comments Download
A chrome/browser/browser_util_win.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/browser_util_win.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/process_singleton.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
Please, take a look.
9 years, 8 months ago (2011-04-14 23:35:44 UTC) #1
James Hawkins
9 years, 8 months ago (2011-04-14 23:37:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698