au_test_harness/update_exception.py - Issue 6857004: Clean up extreme verbosity of logs in test harness.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: au_test_harness/update_exception.py

Issue 6857004: Clean up extreme verbosity of logs in test harness. (Closed) Base URL: http://git.chromium.org/git/crostestutils.git@master

Patch Set: Reenable test Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.	1 # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Module containing update exceptions."""	5 """Module containing update exceptions."""

6	6

7 class UpdateException(Exception):	7 class UpdateException(Exception):

8 """Exception thrown when _UpdateImage or _UpdateUsingPayload fail"""	8 """Exception thrown when _UpdateImage or _UpdateUsingPayload fail"""

9 def __init__(self, code, stdout):	9 def __init__(self, code, stdout):
davidjames 2011/04/15 17:52:09 s/stdout/output/ since it includes all output. Can s/stdout/output/ since it includes all output. Can you also add documentation explaining that output should contain both stdout and stderr all combined into one variable? sosa 2011/04/18 21:12:44 Done. Changed to output to be more vague. Doesn' Show quoted text On 2011/04/15 17:52:09, davidjames wrote: > s/stdout/output/ since it includes all output. Can you also add documentation > explaining that output should contain both stdout and stderr all combined into > one variable? Done. Changed to output to be more vague. Doesn't necessarily require both depending on what the dev wants to show.
	10 super(UpdateException, self).__init__(stdout)

10 self.code = code	11 self.code = code

11 self.stdout = stdout	12 self.stdout = stdout

OLD	NEW

« au_test_harness/parallel_test_job.py ('K') | « au_test_harness/parallel_test_job.py ('k') | au_test_harness/vm_au_worker.py » ('j') | au_test_harness/vm_au_worker.py » ('J')