Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: content/content_common.gypi

Issue 6854027: Only add a WebKit dependency for shared library build. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_common.gypi
===================================================================
--- content/content_common.gypi (revision 81617)
+++ content/content_common.gypi (working copy)
@@ -12,7 +12,6 @@
'../skia/skia.gyp:skia',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/npapi/npapi.gyp:npapi',
- '../third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
'../ui/gfx/gl/gl.gyp:gl',
'../webkit/support/webkit_support.gyp:appcache',
'../webkit/support/webkit_support.gyp:blob',
@@ -211,6 +210,16 @@
'common/worker_messages.h',
],
'conditions': [
+ # If we add this dependency on Windows, then chrome_frame.dll gets
+ # bloated with a lot of WebKit code unnecessairly. So don't add a
+ # dependency for now, which is technically correct, but not necessary,
+ # until the code that's shared between common and chrome frame is split
+ # into a new target.
+ ['library=="shared_library"', {
+ 'dependencies': [
+ '../third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
+ ],
+ }],
['OS=="win"', {
'msvs_guid': '062E9260-304A-4657-A74C-0D3AA1A0A0A4',
'sources': [
« no previous file with comments | « chrome_frame/chrome_frame.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698