Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 6854022: Inhibit python subprocess from generating .pyc files anymore. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Inhibit python subprocess from generating .pyc files anymore. This would case a failure when: - a .py file is moved - *.pyc is in svn:ignore, causing the .pyc to not be deleted. - the new .py modifies its API. - another .py imports the old .py and uses the new API. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -62 lines) Patch
M presubmit_support.py View 1 chunk +70 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-14 15:21:43 UTC) #1
Dirk Pranke
The diff makes it hard to be sure, but it looks like the only change ...
9 years, 8 months ago (2011-04-14 21:56:06 UTC) #2
M-A Ruel
9 years, 8 months ago (2011-04-18 14:09:32 UTC) #3
On 2011/04/14 21:56:06, Dirk Pranke wrote:
> The diff makes it hard to be sure, but it looks like the only change in this
is
> to set the env variable and wrap the whole thing in a try...finally block,
> right?

Right, sorry about the poor diff, it'd be nice if the patch beautifier could
handle re-alignment better.

> LGTM assuming that's true.

Powered by Google App Engine
This is Rietveld 408576698