memento_updater: reduce message flood by controlling wget output format

memento_updater: reduce message flood by controlling wget output format

In factory download stage, it's really hard to find out the error and catch
messages in time because wget simply floods the screen.

Memento updater usually downloads large files (hundreds of mega bytes),
so using --progress=dot:mega should be better.

BUG=none
TEST=create factory install shim, run with factory process;
     seeing the dots in a slower speed.

Change-Id: I5483e50765d49bdc0c12387c82eacfd6a64c66da

R=adlr@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3a70e9c

[adlr, 2011-04-14 17:36:17]

LGTM

On Thu, Apr 14, 2011 at 4:46 AM, <hungte@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> memento_updater: reduce message flood by controlling wget output format
>
> In factory download stage, it's really hard to find out the error and catch
> messages in time because wget simply floods the screen.
>
> Memento updater usually downloads large files (hundreds of mega bytes),
> so using --progress=dot:mega should be better.
>
> BUG=none
> TEST=create factory install shim, run with factory process;
>     seeing the dots in a slower speed.
>
> Change-Id: I5483e50765d49bdc0c12387c82eacfd6a64c66da
>
> R=adlr@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6854018/
>
> SVN Base: ssh://gitrw.chromium.org:9222/memento_softwareupdate.git@master
>
> Affected files:
>  M memento_updater.sh
>
>
> Index: memento_updater.sh
> diff --git a/memento_updater.sh b/memento_updater.sh
> index
>
4bc8e1cd4ce74de3bee328d4e9636448d0126504..3e3a8adc59dc7c327009991c153a6c7ff9a307ca
> 100755
> --- a/memento_updater.sh
> +++ b/memento_updater.sh
> @@ -230,7 +230,7 @@ if [ "$KINSTALL_DEV" != "none" ]; then
>   WRITE_COMMAND='"$(dirname "$0")"/split_write "$KINSTALL_DEV"
> "$INSTALL_DEV"'
>  fi
>
> -COMMAND='wget -O - --load-cookies <(echo "$COOKIES") \
> +COMMAND='wget --progress=dot:mega -O - --load-cookies <(echo "$COOKIES") \
>   "$IMG_URL" 2>> "$MEMENTO_AU_LOG" | \
>   tee >(openssl sha1 -binary | openssl base64 > "$CHECKSUM_FILE") | \
>   gzip -d | '${WRITE_COMMAND}' ; echo ${PIPESTATUS[*]}'
>
>
>