Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 6853030: avoid hard coded NIC names from network_DisableInterface test (Closed)

Created:
9 years, 8 months ago by ggg
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Sam Leffler
Visibility:
Public.

Description

avoid hard coded NIC names from network_DisableInterface test "all" keyword means all interfaces listed in /sys/class/net/ EXCEPT lo and sit*. BUG=chromium-os:14106 TEST=ran test on Seaboard locally (has eth0 and eth1) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8dd8dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M client/site_tests/network_DisableInterface/control View 1 chunk +1 line, -3 lines 0 comments Download
M client/site_tests/network_DisableInterface/network_DisableInterface.py View 3 chunks +20 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ggg
This is one of the tests that was failing in BVT on ARM. This CL ...
9 years, 8 months ago (2011-04-14 22:03:41 UTC) #1
Mandeep Singh Baines
LGTM
9 years, 8 months ago (2011-04-15 21:46:03 UTC) #2
ggg
9 years, 8 months ago (2011-04-15 23:09:22 UTC) #3
On 2011/04/15 21:46:03, Mandeep Singh Baines wrote:
> LGTM


pushed - thanks :)

Powered by Google App Engine
This is Rietveld 408576698