[Sync] Move some extension-sync-related logic to ExtensionService

chrome/browser/sync/glue/extension_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_
 #define CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_
 #pragma once
 
 // This file contains some low-level utility functions used by
 // extensions sync.
 
 #include <string>
 
-class Extension;
+#include "chrome/common/extensions/extension.h"
+
 class ExtensionPrefs;
 class ExtensionServiceInterface;
+class ExtensionSyncData;
 struct UninstalledExtensionInfo;
 
 namespace sync_pb {
 class ExtensionSpecifics;
 }  // sync_pb
 
 namespace browser_sync {
 
 // Returns whether or not the given extension is one we want to sync.
 bool IsExtensionValid(const Extension& extension);
@@ skipping 50 matching lines @@
     const sync_pb::ExtensionSpecifics& a,
     const sync_pb::ExtensionSpecifics& b);
 
 // Fills |specifics| with information taken from |extension|, which
 // must be a syncable extension.  |specifics| will be valid after this
 // function is called.
 void GetExtensionSpecifics(const Extension& extension,
                            const ExtensionServiceInterface& extension_service,
                            sync_pb::ExtensionSpecifics* specifics);
 
-// Returns whether or not the extension should be updated according to
-// the specifics.  |extension| must be syncable and |specifics| must
-// be valid.
-bool IsExtensionOutdated(const Extension& extension,
-                         const sync_pb::ExtensionSpecifics& specifics);
-
 // Merge |specifics| into |merged_specifics|.  Both must be valid and
 // have the same ID.  The merge policy is currently to copy the
 // non-user properties of |specifics| into |merged_specifics| (and the
 // user properties if |merge_user_properties| is set) if |specifics|
 // has a more recent or the same version as |merged_specifics|.
 void MergeExtensionSpecifics(
     const sync_pb::ExtensionSpecifics& specifics,
     bool merge_user_properties,
     sync_pb::ExtensionSpecifics* merged_specifics);
 
+// Fills |sync_data| with the data from |specifics|.  Returns true iff
+// succesful.
+bool GetExtensionSyncData(
+    const sync_pb::ExtensionSpecifics& specifics,
+    ExtensionSyncData* sync_data);
+
+// Predicates used to filter sets of extensions.
+
+bool IsSyncableExtension(Extension::Type type, const GURL& update_url);
+
+bool IsValidAndSyncableExtension(const Extension& extension);
+
+bool IsSyncableApp(Extension::Type type);
+
+bool IsValidAndSyncableApp(
+    const Extension& extension);
+
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_EXTENSION_UTIL_H_