Issue 6852023: Show version of Flash plugin on about:version. If no flash plugin is

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6852023: Show version of Flash plugin on about:version. If no flash plugin is (Closed)

Created:
9 years, 8 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Show version of Flash plugin on about:version. If no flash plugin is enabled, we show "(disabled)". BUG=45241 TEST=Open about:version and you should see the Flash version. Disable Flash using about:plugins and about:version should update accordingly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81816

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -2 lines)			Patch
	M	chrome/browser/browser_about_handler.cc	View		2 chunks	+25 lines, -2 lines	1 comment	Download
	M	chrome/browser/resources/about_version.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

9 years, 8 months ago (2011-04-15 21:16:32 UTC) #3

lgtm

See comment about more IO on this thread.

http://codereview.chromium.org/6852023/diff/1/chrome/browser/browser_about_ha...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/6852023/diff/1/chrome/browser/browser_about_ha...
chrome/browser/browser_about_handler.cc:774: if
(webkit::npapi::IsPluginEnabled(info_array[i])) {
does this cause the plugin dll to be loaded on this thread?

Expand Messages | Collapse Messages