Issue 6852004: Move bvt suite into test harness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6852004: Move bvt suite into test harness. (Closed)

Created:
9 years, 8 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/crostestutils.git@master

Visibility:
Public.

Description

Move bvt suite into test harness. Change-Id: I816fb4825814048aeb911e206067b9e1f6b8cfe4 BUG=chromium-os:12950 TEST=Ran it with buildbot change. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e3bf9c0

Patch Set 1 #

Patch Set 2 : Fix to parallel job #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Pass rate #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	au_test_harness/au_test.py	View	1 2	2 chunks	+12 lines, -2 lines	0 comments	Download
	M	au_test_harness/vm_au_worker.py	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgarrett

9 years, 8 months ago (2011-04-14 00:08:17 UTC) #2

LGTM, except that doesn't whoever was explicitly calling "SimpleTest" need to be
updated? Or will it catch both new test because they share the prefix?

http://codereview.chromium.org/6852004/diff/1001/au_test_harness/parallel_tes...
File au_test_harness/parallel_test_job.py (right):

http://codereview.chromium.org/6852004/diff/1001/au_test_harness/parallel_tes...
au_test_harness/parallel_test_job.py:67: return (active_count, active_job)
This looks like a valid, but separate change. Doesn't need another change list,
but I'd put it in the description.

Expand Messages | Collapse Messages