net/base/mime_util.cc - Issue 6851016: multiple files: Move from DCHECK to DCHECK_EQ

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/mime_util.cc

Issue 6851016: multiple files: Move from DCHECK to DCHECK_EQ (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added name to Authors file, converted old DCHECKs in 2 more files Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/mime_util.cc

diff --git a/net/base/mime_util.cc b/net/base/mime_util.cc

index 988922edcfb5550a0d37cc52851e0cea6a80b58d..a94dd31d8b70ad43b52c4a164fa48639aef7bc89 100644

--- a/net/base/mime_util.cc

+++ b/net/base/mime_util.cc

@@ -384,9 +384,9 @@ bool MimeUtil::IsSupportedMimeType(const std::string& mime_type) const {

bool MimeUtil::MatchesMimeType(const std::string &mime_type_pattern,

const std::string &mime_type) const {

- // verify caller is passing lowercase

- DCHECK(mime_type_pattern == StringToLowerASCII(mime_type_pattern));

- DCHECK(mime_type == StringToLowerASCII(mime_type));

+ // verify caller is passing lowercase

Lei Zhang 2011/04/15 18:37:18 Oh ya, remove extra whitespace please.

+ DCHECK_EQ(StringToLowerASCII(mime_type_pattern), mime_type_pattern);

+ DCHECK_EQ(StringToLowerASCII(mime_type), mime_type);

// This comparison handles absolute maching and also basic

// wildcards. The plugin mime types could be:

« no previous file with comments | « ipc/ipc_channel_posix.cc ('k') | no next file » | no next file with comments »