multiple files: Move from DCHECK to DCHECK_EQ

Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).
This is my first attempt at contributing, so please tell me where I'm going wrong.


BUG=58409
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81988

[David M Futcher, 2011-04-14 14:32:17]

Requesting reviews for my patch from the above people as they appeared commonly
in the "git blame" for the file in question.

[Lei Zhang, 2011-04-14 19:39:21]

Thanks for contributing. This is a good start, but would you mind doing a few
more similar fixes in the same Change List (CL)?

Also, have you signed the Google CLA? If so, you should also add your name to
the AUTHORS file.

http://codereview.chromium.org/6851016/diff/1/base/linux_util.cc
File base/linux_util.cc (right):

http://codereview.chromium.org/6851016/diff/1/base/linux_util.cc#newcode65
base/linux_util.cc:65: DCHECK_EQ(state_, STATE_CHECK_STARTED);
It's DCHECK_EQ(expected_result, actual_result), so the two arguments are
reversed.

[David M Futcher, 2011-04-15 10:02:31]

Have signed the agreement and added name to AUTHORS. Fixed my change to
base/linux_util.cc and changed the DCHECKs in ipc/ipc_channel_posix.cc and
net/base/mime_util.cc.

Thanks in advance for reviewing this.

[Lei Zhang, 2011-04-15 18:33:14]

LGTM

[commit-bot: I haz the power, 2011-04-15 18:34:05]

Presubmit check for 6851016-4001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Found line ending with white spaces in:

***************
net/base/mime_util.cc, line 387
***************

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/linux_util.cc

[Lei Zhang, 2011-04-15 18:37:17]

Evan: OWNER review.

http://codereview.chromium.org/6851016/diff/4001/net/base/mime_util.cc
File net/base/mime_util.cc (right):

http://codereview.chromium.org/6851016/diff/4001/net/base/mime_util.cc#newcod...
net/base/mime_util.cc:387: // verify caller is passing lowercase
Oh ya, remove extra whitespace please.

[Evan Martin, 2011-04-15 18:39:20]

LGTM with whitespace removed

[David M Futcher, 2011-04-16 16:43:56]

Removed the trailing whitespace (sorry, noob mistake).

[David M Futcher, 2011-04-18 20:01:19]

48-hour bump. Can someone check this (shouldn't be too much as I have two LGTM
with minor caveats that I've corrected). Thanks in advance.

[commit-bot: I haz the power, 2011-04-18 20:07:11]

Change committed as 81988