Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 6849012: update WebGL to initial release 1.0.0 (Closed)

Created:
9 years, 8 months ago by ilja
Modified:
9 years, 7 months ago
Reviewers:
zmo, zbehan, ihf
CC:
chromium-os-reviews_chromium.org, ericli, DaleCurtis, zel
Visibility:
Public.

Description

- updated tarball with newest test suite - created new patch - transfer more detailed information about failures from browser to autotest - waive failures that are not yet fixed in Chrome - transfer text summary from test BUG=chromium-os:14112 TEST= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d92193e

Patch Set 1 #

Patch Set 2 : move tarball to production url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -69 lines) Patch
A client/site_tests/graphics_WebGLConformance/README View 1 1 chunk +14 lines, -0 lines 0 comments Download
M client/site_tests/graphics_WebGLConformance/graphics_WebGLConformance.py View 1 3 chunks +88 lines, -18 lines 0 comments Download
D client/site_tests/graphics_WebGLConformance/r11002.patch View 1 chunk +0 lines, -48 lines 0 comments Download
M client/site_tests/graphics_WebGLConformance/scripts/make-tarball View 2 chunks +3 lines, -3 lines 0 comments Download
A client/site_tests/graphics_WebGLConformance/webgl-conformance-1.0.0.patch View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ilja
Inviting first feedback.
9 years, 8 months ago (2011-04-14 02:55:13 UTC) #1
zbehan
First piece of feedback: I'd generally welcome if we were commiting less binary tarballs into ...
9 years, 8 months ago (2011-04-14 23:46:53 UTC) #2
ihf
That is a fair observation. Now I did ask you yesterday how to put my ...
9 years, 8 months ago (2011-04-15 00:16:10 UTC) #3
ilja
Moved tarball as suggested and adjusted the code. Anything else? On 2011/04/15 00:16:10, ihf_google.com wrote: ...
9 years, 8 months ago (2011-04-17 22:42:09 UTC) #4
zbehan
Much better from my point of view: LGTM , though since this really looks more ...
9 years, 8 months ago (2011-04-17 22:57:17 UTC) #5
zmo
The change looks fine. One thing I want to mention is that the current 1.0.0 ...
9 years, 8 months ago (2011-04-18 16:48:06 UTC) #6
ilja
I will certainly update the suite once you let me know there is a new ...
9 years, 8 months ago (2011-04-18 18:44:36 UTC) #7
zmo
9 years, 8 months ago (2011-04-18 19:07:18 UTC) #8
Right now these webgl conformance tests are running as LayoutTests, so
it's running with --in-process-webgl and on top of mesa library.  I am
planning to run them as Browser tests on top of NVIDIA gpu as part of
the gpu tests.

On Mon, Apr 18, 2011 at 11:44 AM,  <ihf@chromium.org> wrote:
> I will certainly update the suite once you let me know there is a new
> version.
>
> That said there would IMHO a great benefit of running this and similar WebGL
> tests already in Chromium before pulling the browser to the OS which happens
> only once a day. Is there anything active/planned right now?
>
> On 2011/04/18 16:48:06, zmo wrote:
>>
>> The change looks fine.  One thing I want to mention is that the current
>> 1.0.0
>> suite still has some bugs (we fixed them on the main trunk), so you might
>> want
>> to make another shot soon.
>
>
>
> http://codereview.chromium.org/6849012/
>

Powered by Google App Engine
This is Rietveld 408576698