Disable the irt_tls_test for bitcode.

Disable the irt_tls_test for bitcode.

This disables the new irt_tls_test in the bitcode build,
where no objdump tool is available.

R=mseaborn@google.com,bsy@google.com
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=4871

[bsy, 2011-04-14 00:37:32]

lgtm

[Mark Seaborn, 2011-04-14 00:46:35]

LGTM too.

On 13 April 2011 17:33, <mcgrathr@chromium.org> wrote:

> Reviewers: mseaborn - please use other, bsy,
>
> Description:
> Disable the irt_tls_test for bitcode.
>
> This disables the new irt_tls_test in the bitcode build,
> where no objdump tool is available.
>

It's not just that objdump isn't there:  the PNaCl-generated irt.nexe for
x86-32 will contain %gs references and so will fail the test.

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[noelallen_use_chromium, 2011-04-14 00:53:25]

I just disabled the test period.  Mac was still red.

-Noel

On Wed, Apr 13, 2011 at 5:46 PM, Mark Seaborn <mseaborn@chromium.org> wrote:

> LGTM too.
>
>
> On 13 April 2011 17:33, <mcgrathr@chromium.org> wrote:
>
>> Reviewers: mseaborn - please use other, bsy,
>>
>> Description:
>> Disable the irt_tls_test for bitcode.
>>
>> This disables the new irt_tls_test in the bitcode build,
>> where no objdump tool is available.
>>
>
> It's not just that objdump isn't there:  the PNaCl-generated irt.nexe for
> x86-32 will contain %gs references and so will fail the test.
>
> Cheers,
> Mark
>
>  --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to
> native-client-reviews@googlegroups.com.
> To unsubscribe from this group, send email to
> native-client-reviews+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/native-client-reviews?hl=en.
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.