Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 6845002: OpenBSD: compatibility fixes for the build system. (Closed)

Created:
9 years, 8 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

OpenBSD: compatibility fixes for the build system. - switch from /bin/bash to /bin/sh (bash is not a part of base system on OpenBSD) - switch from /usr/bin/python to /usr/bin/env python (python is not a part of base system on OpenBSD) BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81550

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/gyp_chromium View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/python_arch.sh View 1 2 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
9 years, 8 months ago (2011-04-13 08:27:24 UTC) #1
mark_mentovai.com
LGTM http://codereview.chromium.org/6845002/diff/2001/build/linux/python_arch.sh File build/linux/python_arch.sh (right): http://codereview.chromium.org/6845002/diff/2001/build/linux/python_arch.sh#newcode16 build/linux/python_arch.sh:16: exit 0; Drop the semicolon on this line ...
9 years, 8 months ago (2011-04-13 14:07:39 UTC) #2
Nirnimesh
LGTM
9 years, 8 months ago (2011-04-13 18:06:36 UTC) #3
Paweł Hajdan Jr.
http://codereview.chromium.org/6845002/diff/2001/build/linux/python_arch.sh File build/linux/python_arch.sh (right): http://codereview.chromium.org/6845002/diff/2001/build/linux/python_arch.sh#newcode16 build/linux/python_arch.sh:16: exit 0; On 2011/04/13 14:07:39, mark_mentovai.com wrote: > Drop ...
9 years, 8 months ago (2011-04-13 18:36:30 UTC) #4
Mark Mentovai
LGTM
9 years, 8 months ago (2011-04-13 18:36:57 UTC) #5
commit-bot: I haz the power
9 years, 8 months ago (2011-04-13 19:02:45 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698