buildbot/prebuilt_unittest.py - Issue 6840064: Restart codereview issue 6792042

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: buildbot/prebuilt_unittest.py

Issue 6840064: Restart codereview issue 6792042 (Closed) Base URL: http://git.chromium.org/git/chromite.git@master

Patch Set: Fixed shell case, and prebuilt not to exercise it. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: buildbot/prebuilt_unittest.py

diff --git a/buildbot/prebuilt_unittest.py b/buildbot/prebuilt_unittest.py

index 27506a35de1d45921ae37b7d9a42842ebf70e703..73d1e050ec1f1df17210edd31eea75adbdd90b44 100755

--- a/buildbot/prebuilt_unittest.py

+++ b/buildbot/prebuilt_unittest.py

@@ -401,7 +401,7 @@ class TestUploadPrebuilt(unittest.TestCase):

'rsync -av --chmod=a+r fake %s/Packages' % full_remote_path,

'rsync -Rav private.tbz2 %s/' % full_remote_path]

for cmd in cmds:

- prebuilt._RetryRun(cmd, shell=True, cwd='/packages').AndReturn(True)

+ prebuilt._RetryRun(cmd, cwd='/packages').AndReturn(True)

self.mox.ReplayAll()

uri = self.pkgindex.header['URI']

uploader = prebuilt.PrebuiltUploader('chromeos-prebuilt:/dir',