Restart codereview issue 6792042

buildbot/cbuildbot_commands.py

 # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Module containing the various individual commands a builder can run."""
 
 import os
 import re
 import shutil
 import sys
@@ skipping 162 matching lines @@
 
 
 def SetupBoard(buildroot, board='x86-generic'):
   """Wrapper around setup_board."""
   cwd = os.path.join(buildroot, 'src', 'scripts')
   cros_lib.OldRunCommand(
       ['./setup_board', '--fast', '--default', '--board=%s' % board], cwd=cwd,
       enter_chroot=True)
 
 
-def Build(buildroot, emptytree, build_autotest=True, usepkg=True):
+def Build(buildroot, emptytree, build_autotest=True, usepkg=True,
+          extra_env=None):
   """Wrapper around build_packages."""
   cwd = os.path.join(buildroot, 'src', 'scripts')
   cmd = ['./build_packages']
+  env = {}
   if not build_autotest: cmd.append('--nowithautotest')
   if not usepkg: cmd.append('--nousepkg')
   if emptytree:
-    cmd = ['sh', '-c', 'EXTRA_BOARD_FLAGS=--emptytree %s' % ' '.join(cmd)]
+    env['EXTRA_BOARD_FLAGS'] = '--emptytree'
+  if extra_env:
+    env.update(extra_env)

[dgarrett, 2011/04/18 21:17:38]

Shouldn't --emptytree be appended to the env value for 'EXTRA_BOARD_FLAGS'? If a
caller both set that flag and passed in some unrelated EXTRA_BOARD_FLAGS then
--emptytree would be lost.

[Peter Mayo, 2011/04/19 03:59:39]

Seems like overkill, but sure.  Similarly, I don't know if there is a --fulltree
that should be removed from the resulting array.  Of course, updating it means
that I should move the generic update to before it.

 
-  cros_lib.OldRunCommand(cmd, cwd=cwd, enter_chroot=True)
+  cros_lib.RunCommand(cmd, cwd=cwd, enter_chroot=True, extra_env=env)
 
 
-def BuildImage(buildroot):
+def BuildImage(buildroot, extra_env=None):
   _WipeOldOutput(buildroot)
 
   cwd = os.path.join(buildroot, 'src', 'scripts')
-  cros_lib.OldRunCommand(['./build_image', '--replace'], cwd=cwd,
-                         enter_chroot=True)
+  cros_lib.RunCommand(['./build_image', '--replace'], cwd=cwd,
+                         enter_chroot=True, extra_env=extra_env)
 
 
-def BuildVMImageForTesting(buildroot):
+def BuildVMImageForTesting(buildroot, extra_env=None):
   (vdisk_size, statefulfs_size) = _GetVMConstants(buildroot)
   cwd = os.path.join(buildroot, 'src', 'scripts')
-  cros_lib.OldRunCommand(['./image_to_vm.sh',
-                          '--test_image',
-                          '--full',
-                          '--vdisk_size=%s' % vdisk_size,
-                          '--statefulfs_size=%s' % statefulfs_size,
-                         ], cwd=cwd, enter_chroot=True)
+  cros_lib.RunCommand(['./image_to_vm.sh',
+                       '--test_image',
+                       '--full',
+                       '--vdisk_size=%s' % vdisk_size,
+                       '--statefulfs_size=%s' % statefulfs_size,
+                      ], cwd=cwd, enter_chroot=True, extra_env=extra_env)
 
 
 def RunUnitTests(buildroot, full):
   cwd = os.path.join(buildroot, 'src', 'scripts')
 
   cmd = ['cros_run_unit_tests']
 
   # If we aren't running ALL tests, then restrict to just the packages
   #   uprev noticed were changed.
   if not full:
@@ skipping 248 matching lines @@
 
   archive_url = None
   key_re = re.compile('^%s=(.*)$' % _CROS_ARCHIVE_URL)
   for line in result.output.splitlines():
     line_match = key_re.match(line)
     if line_match:
       archive_url = line_match.group(1)
 
   assert archive_url, 'Archive Build Failed to Provide Archive URL'
   return archive_url