vboot_reference: check developer firmware before running make_dev_ssd

vboot_reference: check developer firmware before running make_dev_ssd

Developers may turn on developer switch, enter shell, and then try to run
make_dev_ssd without switching to developer firmware / dev root key.
And that would make the system showing "NO GOOD" or "INSERT" screen
after reboot.

For sanity check, we should check if firmware type is "developer" before running
make_dev_ssd.

BUG=none
TEST=(using normale firmware) make_dev_ssd # seeing the error messages
     sudo chromeos-firmwareupdate --mode=todev; sudo reboot
     (using developer firmware) make_dev_ssd # not seeing error

Change-Id: Id62959c91c39b0bbcca604c9e83fd087e3727b8b

R=rspangler@chromium.org

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=83728d0

[Randall Spangler, 2011-04-14 16:19:10]

LGTM with suggestions.

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
File scripts/image_signing/make_dev_ssd.sh (right):

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:299: debug_msg "Firmware compatbility
sanity check"
compatibility

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:312: sudo chromeos-firmwareupdate --force
--mode=todev
If --force is required now, also should change the banner/motd for the root
shell (in a separate CL, of course)

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:314: - To change system rootkey: disable
write protection, then type command:
disable firmware write protection

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:319: command again with -f param:
-f --> --force

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:321: sudo ./make_dev_ssd.sh --force
Bonus points for echoing the original args ($@) + --force.

[Hung-Te, 2011-04-15 03:06:59]

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
File scripts/image_signing/make_dev_ssd.sh (right):

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:299: debug_msg "Firmware compatbility
sanity check"
On 2011/04/14 16:19:10, Randall Spangler wrote:
> compatibility

Done.

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:312: sudo chromeos-firmwareupdate --force
--mode=todev
On 2011/04/14 16:19:10, Randall Spangler wrote:
> If --force is required now, also should change the banner/motd for the root
> shell (in a separate CL, of course)

 It actually not required - but just to make sure people won't get confused if
they get a system with that disabled, I add --force in the instruction.
 Maybe the better place is to add "disabled, please add --force" inside the
updater itself.
 I'll remove the --force and make another CL inside the updater to describe the
--force.

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:314: - To change system rootkey: disable
write protection, then type command:
On 2011/04/14 16:19:10, Randall Spangler wrote:
> disable firmware write protection

Done.

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:319: command again with -f param:
On 2011/04/14 16:19:10, Randall Spangler wrote:
> -f --> --force

Done.

http://codereview.chromium.org/6840047/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_ssd.sh:321: sudo ./make_dev_ssd.sh --force
On 2011/04/14 16:19:10, Randall Spangler wrote:
> Bonus points for echoing the original args ($@) + --force.

Done.