Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 6840024: Moving locale code from i18n-extension.cc. Each part of the API now has separate cc file, and onl... (Closed)

Created:
9 years, 8 months ago by Nebojša Ćirić
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
v8-dev
Visibility:
Public.

Description

Moving locale code from i18n-extension.cc. Each part of the API now has separate cc file, and only extension related code is left in i18n-extension.{cc,h}. There are no functional changes in this CL. Committed: http://code.google.com/p/v8/source/detail?r=7608

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -161 lines) Patch
M src/extensions/experimental/experimental.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/extensions/experimental/i18n-extension.h View 1 chunk +0 lines, -10 lines 0 comments Download
M src/extensions/experimental/i18n-extension.cc View 3 chunks +9 lines, -151 lines 0 comments Download
A src/extensions/experimental/i18n-locale.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A src/extensions/experimental/i18n-locale.cc View 1 1 chunk +172 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
As far as getting locale out of i18n-extension.cc/h, it looks good to me. Pls, make ...
9 years, 8 months ago (2011-04-13 20:34:10 UTC) #1
Nebojša Ćirić
Done. My ~/.subversion/config has native instead of LF. I'll change that too. On 2011/04/13 20:34:10, ...
9 years, 8 months ago (2011-04-13 20:45:42 UTC) #2
jungshik at Google
9 years, 8 months ago (2011-04-13 21:08:45 UTC) #3
LG

Powered by Google App Engine
This is Rietveld 408576698