Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 6840012: Fix a just-introduced bug in polymorphic inlining. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix a just-introduced bug in polymorphic inlining. When inlining a polymorphic variant, the inlined function indicates we should bailout of the entire compilation by setting the stack overflow flag on the visitor. We need to check this flag and bailout if a call to TryInline succeeds and it is not in tail position in a graph builder function. R=fschneider@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/hydrogen.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-04-13 11:56:54 UTC) #1
fschneider
9 years, 8 months ago (2011-04-13 11:59:09 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698