Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 6840010: Css fix for list. (Closed)

Created:
9 years, 8 months ago by dgozman%chromium.org
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews), kerz_chromium, zel, csilv, dhollowa, ojan
Visibility:
Public.

Description

Css fix for list. Css selector using -webkit-any somehow has more priority than the following standard selector. Example: -webkit-any(list, grid) { height: 100px; --This is used. } list { height: 200px; --This is not used. } BUG=chromium:79468 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81928

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M chrome/browser/resources/shared/css/list.css View 1 4 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgozman%chromium.org
Hello Erik, There was a regression with lists. May you have a look, please? Also, ...
9 years, 8 months ago (2011-04-15 11:01:37 UTC) #1
arv (Not doing code reviews)
LGTM I talked to Ojan about the specificity issue and I think the conclusion was ...
9 years, 8 months ago (2011-04-15 18:48:03 UTC) #2
ojan
9 years, 8 months ago (2011-04-15 18:52:06 UTC) #3
FWIW, our current specificity behavior matches Mozilla. Both WebKit and
Mozilla plan to improve it though. I hope to take a look at this next week.

On Fri, Apr 15, 2011 at 11:48 AM, <arv@chromium.org> wrote:

> LGTM
>
> I talked to Ojan about the specificity issue and I think the conclusion was
> to
> try to use the max specificity instead.
>
> http://codereview.chromium.org/6840010/
>

Powered by Google App Engine
This is Rietveld 408576698