Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4951)

Unified Diff: chrome/browser/first_run/try_chrome_dialog_view.cc

Issue 6840003: first-run: Refactor Upgrade class into a common upgrade_util API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: upgrade_utils -> upgrade_util Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/first_run/try_chrome_dialog_view.h ('k') | chrome/browser/first_run/upgrade.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run/try_chrome_dialog_view.cc
diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc
index 5fa9aa20f945ebe78e5e2abbaf1f8b07c752d4f4..6669887d23ff61bba43ebd474167abee0ef1ae28 100644
--- a/chrome/browser/first_run/try_chrome_dialog_view.cc
+++ b/chrome/browser/first_run/try_chrome_dialog_view.cc
@@ -36,13 +36,13 @@ TryChromeDialogView::TryChromeDialogView(size_t version)
popup_(NULL),
try_chrome_(NULL),
kill_chrome_(NULL),
- result_(Upgrade::COUNT) {
+ result_(upgrade_util::COUNT) {
}
TryChromeDialogView::~TryChromeDialogView() {
}
-Upgrade::TryResult TryChromeDialogView::ShowModal(
+upgrade_util::TryResult TryChromeDialogView::ShowModal(
ProcessSingleton* process_singleton) {
using views::GridLayout;
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
@@ -57,7 +57,7 @@ Upgrade::TryResult TryChromeDialogView::ShowModal(
popup_ = views::Widget::CreateWidget(params);
if (!popup_) {
NOTREACHED();
- return Upgrade::DIALOG_ERROR;
+ return upgrade_util::DIALOG_ERROR;
}
gfx::Rect pos(310, 160);
@@ -71,7 +71,7 @@ Upgrade::TryResult TryChromeDialogView::ShowModal(
views::GridLayout* layout = views::GridLayout::CreatePanel(root_view);
if (!layout) {
NOTREACHED();
- return Upgrade::DIALOG_ERROR;
+ return upgrade_util::DIALOG_ERROR;
}
root_view->SetLayoutManager(layout);
@@ -121,13 +121,13 @@ Upgrade::TryResult TryChromeDialogView::ShowModal(
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
if (!dist) {
NOTREACHED() << "Cannot determine browser distribution";
- return Upgrade::DIALOG_ERROR;
+ return upgrade_util::DIALOG_ERROR;
}
BrowserDistribution::UserExperiment experiment;
if (!dist->GetExperimentDetails(&experiment, version_) ||
!experiment.heading) {
NOTREACHED() << "Cannot determine which headline to show.";
- return Upgrade::DIALOG_ERROR;
+ return upgrade_util::DIALOG_ERROR;
}
string16 heading = l10n_util::GetStringUTF16(experiment.heading);
views::Label* label = new views::Label(heading);
@@ -202,14 +202,14 @@ void TryChromeDialogView::ButtonPressed(views::Button* sender,
const views::Event& event) {
if (sender->tag() == BT_CLOSE_BUTTON) {
// The user pressed cancel or the [x] button.
- result_ = Upgrade::NOT_NOW;
+ result_ = upgrade_util::NOT_NOW;
} else if (!try_chrome_) {
// We don't have radio buttons, the user pressed ok.
- result_ = Upgrade::TRY_CHROME;
+ result_ = upgrade_util::TRY_CHROME;
} else {
// The outcome is according to the selected ratio button.
- result_ = try_chrome_->checked() ? Upgrade::TRY_CHROME :
- Upgrade::UNINSTALL_CHROME;
+ result_ = try_chrome_->checked() ? upgrade_util::TRY_CHROME :
+ upgrade_util::UNINSTALL_CHROME;
}
popup_->Close();
MessageLoop::current()->Quit();
« no previous file with comments | « chrome/browser/first_run/try_chrome_dialog_view.h ('k') | chrome/browser/first_run/upgrade.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698