Issue 6839021: first-run: Reland refactor of Upgrade class into upgrade_util API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6839021: first-run: Reland refactor of Upgrade class into upgrade_util API. (Closed)

Created:
9 years, 8 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

first-run: Reland refactor of Upgrade class into upgrade_util API. This fix linux_chromeos build by adding an appropriate #ifdef on upgrade_util_linux.cc. BUG=79203 TEST=None TBR=jhawkins@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81431

Patch Set 1 #

Patch Set 2 : fix linux_chromeos #

Patch Set 3 : one more ifdef for linux_chromeos #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -428 lines)			Patch
M	chrome/app/chrome_exe_main_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View		6 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/browser_main_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_shutdown.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/try_chrome_dialog_view.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/try_chrome_dialog_view.cc	View		5 chunks	+10 lines, -10 lines	0 comments	Download
D	chrome/browser/first_run/upgrade.h	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	chrome/browser/first_run/upgrade.cc	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_gtk.cc	View		1 chunk	+0 lines, -55 lines	0 comments	Download
A	chrome/browser/first_run/upgrade_util.h	View		1 chunk	+83 lines, -0 lines	0 comments	Download
A	chrome/browser/first_run/upgrade_util.cc	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade_util_linux.cc	View	1 2	2 chunks	+19 lines, -19 lines	0 comments	Download
A +	chrome/browser/first_run/upgrade_util_win.cc	View		4 chunks	+26 lines, -31 lines	0 comments	Download
D	chrome/browser/first_run/upgrade_win.cc	View		1 chunk	+0 lines, -157 lines	0 comments	Download
M	chrome/browser/process_singleton.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		5 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/installer/setup/install_worker.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

9 years, 8 months ago (2011-04-13 18:21:10 UTC) #2

LGTM. Start thinking about how we can get rid of the remaining ifdefs!

Expand Messages | Collapse Messages