Issue 6838012: Fix optimized code for Math.round on ia32 platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6838012: Fix optimized code for Math.round on ia32 platform. (Closed)

Created:
9 years, 8 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix optimized code for Math.round on ia32 platform. Committed: http://code.google.com/p/v8/source/detail?r=7600

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	src/ia32/lithium-codegen-ia32.cc	View	1	2 chunks	+24 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

I will test the performance impact of using the sign flag test instead of the ...

9 years, 8 months ago (2011-04-13 09:37:39 UTC) #1

Vitaly Repeshko

9 years, 8 months ago (2011-04-13 21:16:34 UTC) #3

Drive-by comment.

http://codereview.chromium.org/6838012/diff/2001/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6838012/diff/2001/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:2710: Label below_half, done;
I think you can use NearLabel here.

Expand Messages | Collapse Messages