cros-disks.conf - Issue 6838011: adds a signal, fixes a crash, adds syslogging, and marshals disks to d-bus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cros-disks.conf

Issue 6838011: adds a signal, fixes a crash, adds syslogging, and marshals disks to d-bus (Closed) Base URL: ssh://gitrw.chromium.org:9222/cros-disks.git@master

Patch Set: reverts a commom.mk change Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cros-disks.conf

diff --git a/cros-disks.conf b/cros-disks.conf

index a04a6dfd13d799447bf05ca83259d6269fa15f06..8a10895441e86a30eaf22846943361c45193c221 100644

--- a/cros-disks.conf

+++ b/cros-disks.conf

@@ -4,7 +4,7 @@

# cros-disks upstart job

-env CROS_DISKS_LOG_DIR=/var/log/cros-disks

+env CROS_DISKS_LOG_FILE=/var/log/crosdisks.log

Ben Chan 2011/04/13 15:11:47 How about naming it as cros-disks.log for consiste

env CROS_DISKS_UID=213

env CROS_DISKS_GID=213

@@ -15,8 +15,9 @@ respawn

expect fork

pre-start script

- mkdir -p -m 0755 "${CROS_DISKS_LOG_DIR}"

- chown -R cros-disks:cros-disks "${CROS_DISKS_LOG_DIR}"

+ touch "${CROS_DISKS_LOG_FILE}"

+ chown -R cros-disks:cros-disks "${CROS_DISKS_LOG_FILE}"

+ chmod 0755 "${CROS_DISKS_LOG_FILE}"

Ben Chan 2011/04/13 15:11:47 Should the log file permission be 0644? And shoul

end script

exec /sbin/minijail --uid="${CROS_DISKS_UID}" --gid="${CROS_DISKS_GID}" -- /opt/google/cros-disks/disks

« no previous file with comments | « Makefile ('k') | cros-disks.xml » ('j') | disk.cc » ('J')