Issue 6837028: In ProfilerSignalHandler ensure that thread we are trying to sample locked the isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6837028: In ProfilerSignalHandler ensure that thread we are trying to sample locked the isolate. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

In ProfilerSignalHandler ensure that thread we are trying to sample locked the isolate. BUG=http://crbug.com/77725 Committed: http://code.google.com/p/v8/source/detail?r=7612

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/platform-freebsd.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/platform-linux.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 8 months ago (2011-04-13 19:32:02 UTC) #2

LGTM

I agree with your analysis here. See my comment on the bug. I think we should
also guard against the case when it's not us who's sending the signal. We can do
that by checking sampler->IsProfiling() next to sampler->IsActive().

In the future, when the locker/unlocker support for multiple isolates is
improved, this locked-by-current check should not be necessary, because the
thread that unlocked an isolate should have no current isolate.

Expand Messages | Collapse Messages