Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 6837018: Fix Math.round in runtime.cc and x64 optimized code. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix Math.round in runtime.cc and x64 optimized code. Make math-round.js test check both normal and optimized version. Add some cases to the tests. BUG=v8:958 TEST=mjsunit/math-round Committed: http://code.google.com/p/v8/source/detail?r=7599

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -89 lines) Patch
M src/runtime.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +26 lines, -15 lines 2 comments Download
M test/mjsunit/math-round.js View 1 chunk +125 lines, -71 lines 4 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 8 months ago (2011-04-13 08:59:59 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/6837018/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6837018/diff/1/src/x64/lithium-codegen-x64.cc#newcode2733 src/x64/lithium-codegen-x64.cc:2733: // rounding, due to loss of precission, but ...
9 years, 8 months ago (2011-04-13 09:12:45 UTC) #2
Lasse Reichstein
9 years, 8 months ago (2011-04-13 09:35:23 UTC) #3
http://codereview.chromium.org/6837018/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6837018/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:2733: // rounding, due to loss of precission, but
only for a number that's
Fixed, thanks.

http://codereview.chromium.org/6837018/diff/1/test/mjsunit/math-round.js
File test/mjsunit/math-round.js (right):

http://codereview.chromium.org/6837018/diff/1/test/mjsunit/math-round.js#newc...
test/mjsunit/math-round.js:34: assertEquals(expect, doRound(input));
Not necessary, assertEquals correctly distinguishes 0 and -0 since revision
7368.

http://codereview.chromium.org/6837018/diff/1/test/mjsunit/math-round.js#newc...
test/mjsunit/math-round.js:50: testRound(-0, -0.5);
Not any more.

Powered by Google App Engine
This is Rietveld 408576698