Issue 6837012: Add websocket owners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6837012: Add websocket owners (Closed)

Created:
9 years, 8 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, Yuta Kitamura

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add websocket owners BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81407

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
A	chrome/browser/net/websocket_experiment/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/socket_stream/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	net/websockets/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 8 months ago (2011-04-13 08:14:51 UTC) #2

LGTM

On Wed, Apr 13, 2011 at 5:52 AM, <ukai@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Add websocket owners
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/6837012/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  A chrome/browser/net/websocket_experiment/OWNERS
>  A net/socket_stream/OWNERS
>  A net/websockets/OWNERS
>
>
> Index: chrome/browser/net/websocket_experiment/OWNERS
> diff --git a/chrome/browser/net/websocket_experiment/OWNERS
> b/chrome/browser/net/websocket_experiment/OWNERS
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..e9c079f5eb08f048703e859637c2224bacbc731a
> --- /dev/null
> +++ b/chrome/browser/net/websocket_experiment/OWNERS
> @@ -0,0 +1,2 @@
> +ukai@chromium.org
> +yutak@chromium.org
> Index: net/socket_stream/OWNERS
> diff --git a/net/socket_stream/OWNERS b/net/socket_stream/OWNERS
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..e9c079f5eb08f048703e859637c2224bacbc731a
> --- /dev/null
> +++ b/net/socket_stream/OWNERS
> @@ -0,0 +1,2 @@
> +ukai@chromium.org
> +yutak@chromium.org
> Index: net/websockets/OWNERS
> diff --git a/net/websockets/OWNERS b/net/websockets/OWNERS
> new file mode 100644
> index
>
0000000000000000000000000000000000000000..e9c079f5eb08f048703e859637c2224bacbc731a
> --- /dev/null
> +++ b/net/websockets/OWNERS
> @@ -0,0 +1,2 @@
> +ukai@chromium.org
> +yutak@chromium.org
>
>
>

Expand Messages | Collapse Messages