Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 6835028: factory_test_tools: use flimflam to get connection info directly. (Closed)

Created:
9 years, 8 months ago by Hung-Te
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

factory_test_tools: use flimflam to get connection info directly. To preven using "modem status" command, this CL tries to load flimflam tests directly. BUG=chromium-os:13967, chrome-os-partner:2952 TEST=./gft_hwcomp # seeing: 'part_id_3g': ['0XXX:XXXX Some Manufaturuer Some Product'], 'version_3g_firmware': ['Some Vendor 09010012'], Change-Id: I648a1afcfe8a319f4bc3f5c981c12048d0648235 R=yongjaek@chromium.org,jglasgow@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1b50ff1

Patch Set 1 #

Patch Set 2 : update 3g_firmware generation rule to work for models without FirmwareRevision #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -46 lines) Patch
M gft_hwcomp.py View 1 10 chunks +93 lines, -46 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Hung-Te
9 years, 8 months ago (2011-04-13 18:05:00 UTC) #1
Hung-Te
NOTE: the format and content for "3g firmware" may still be changed before commiting. I ...
9 years, 8 months ago (2011-04-13 18:07:23 UTC) #2
yongjaek
R11 is based Y3300, and we got a confirmation from Samsung that Version is the ...
9 years, 8 months ago (2011-04-13 18:45:01 UTC) #3
Hung-Te
I've updated the generation rule so it will try Carrier + Firmware Revision Firmware Revision ...
9 years, 8 months ago (2011-04-14 04:27:57 UTC) #4
Hung-Te
Any feedbacks? thanks
9 years, 8 months ago (2011-04-15 11:11:54 UTC) #5
Jason Glasgow
9 years, 8 months ago (2011-04-15 22:39:44 UTC) #6
http://codereview.chromium.org/6835028/diff/5001/gft_hwcomp.py
File gft_hwcomp.py (right):

http://codereview.chromium.org/6835028/diff/5001/gft_hwcomp.py#newcode601
gft_hwcomp.py:601: (_, attributes) = self.load_flimflam()
Looks okay to me.  I would have used mm.py and gone directly to the modem
instead of going through flimflam, but I guess this works.

Powered by Google App Engine
This is Rietveld 408576698