Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 6835006: Convert to SQLite amalgamation. (Closed)

Created:
9 years, 8 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, brettw, Evan Martin
Visibility:
Public.

Description

Convert to SQLite amalgamation. SQLite generally distributes using a script-generated "Giant file of stuff", called the amalgamation. It's apparently faster, due to more opportunities for optimization, but for Chromium the attraction is that we don't need as many patches to SQLite. Imports of future versions of SQLite should be simpler, so long as an Ubuntu box is available. BUG=71731 TEST=automated testing and watching closely. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -10554 lines) Patch
M third_party/sqlite/README.chromium View 4 chunks +4 lines, -1 line 0 comments Download
A + third_party/sqlite/amalgamation/README View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/sqlite/amalgamation/sqlite3.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/sqlite/fts2.patch View 2 chunks +22 lines, -1 line 0 comments Download
A + third_party/sqlite/google_generate_amalgamation.sh View 1 chunk +6 lines, -5 lines 0 comments Download
D third_party/sqlite/google_generate_preprocessed.sh View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/sqlite/misc.patch View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/sqlite/preprocessed/README View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/sqlite/preprocessed/keywordhash.h View 1 chunk +0 lines, -266 lines 0 comments Download
D third_party/sqlite/preprocessed/opcodes.h View 1 chunk +0 lines, -181 lines 0 comments Download
D third_party/sqlite/preprocessed/opcodes.c View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/sqlite/preprocessed/parse.h View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/sqlite/preprocessed/parse.c View 1 chunk +0 lines, -3792 lines 0 comments Download
D third_party/sqlite/preprocessed/sqlite3.h View 1 chunk +0 lines, -5774 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 4 chunks +15 lines, -138 lines 0 comments Download
M third_party/sqlite/sqlite3.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/ext/fts2/fts2.c View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/sqlite/src/ext/fts2/fts2_tokenizer.c View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/sqlite/src/main.mk View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/sqlite/src/src/main.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/sqlite/src/src/sqlite3ext.h View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/sqlite/src/src/test_autoext.c View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/sqlite/src/test/quick.test View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/sqlite/test.patch View 1 chunk +2 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
There is also amalgamation/sqlite3.c, which was too large to upload. Which is sad, I don't ...
9 years, 8 months ago (2011-04-13 19:50:52 UTC) #1
brettw
9 years, 8 months ago (2011-04-13 20:09:53 UTC) #2
LGTM rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698