Implemented PPB_Broker_Proxy.

webkit/plugins/ppapi/ppb_broker_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_broker_impl.h"
 
 #include "base/logging.h"
 #include "webkit/plugins/ppapi/common.h"
 #include "webkit/plugins/ppapi/plugin_module.h"
 
@@ skipping 49 matching lines @@
 };
 
 }  // namespace
 
 // PPB_Broker_Impl ------------------------------------------------------
 
 PPB_Broker_Impl::PPB_Broker_Impl(PluginInstance* instance)
     : Resource(instance),
       broker_(NULL),
       connect_callback_(),
-      pipe_handle_(0) {
+      pipe_handle_(base::kInvalidPlatformFileValue) {
 }
 
 PPB_Broker_Impl::~PPB_Broker_Impl() {
   if (broker_) {
     broker_->Release(instance());
     broker_ = NULL;
   }
 
-  // TODO(ddorwin): Should the plugin or Chrome free the handle?
-  pipe_handle_ = 0;
+  // The plugin owns the handle.
+  pipe_handle_ = base::kInvalidPlatformFileValue;
 }
 
 const PPB_BrokerTrusted* PPB_Broker_Impl::GetTrustedInterface() {
   return &ppb_brokertrusted;
 }
 
 int32_t PPB_Broker_Impl::Connect(
     PluginDelegate* plugin_delegate,
     PP_CompletionCallback connect_callback) {
   // TODO(ddorwin): Return PP_ERROR_FAILED if plugin is in-process.
@@ skipping 10 matching lines @@
   PP_Resource resource_id = GetReferenceNoAddRef();
   CHECK(resource_id);
   connect_callback_ = new TrackedCompletionCallback(
       instance()->module()->GetCallbackTracker(), resource_id,
       connect_callback);
   return PP_ERROR_WOULDBLOCK;
 }
 
 int32_t PPB_Broker_Impl::GetHandle(int32_t* handle) {
   *handle = pipe_handle_;
-
-  if (!*handle)
-    return PP_ERROR_FAILED;
-
   return PP_OK;
 }
 
 PPB_Broker_Impl* PPB_Broker_Impl::AsPPB_Broker_Impl() {
   return this;
 }
 
+// Transfers ownership of the handle to the plugin.
 void PPB_Broker_Impl::BrokerConnected(int32_t handle) {
   DCHECK(handle);
   pipe_handle_ = handle;
 
   // Synchronous calls are not supported.
   DCHECK(connect_callback_.get() && !connect_callback_->completed());
 
   scoped_refptr<TrackedCompletionCallback> callback;
   callback.swap(connect_callback_);
-  callback->Run(0);  // Will complete abortively if necessary.
+  callback->Run(PP_OK);  // Will complete abortively if necessary.
 }
 
 }  // namespace ppapi
 }  // namespace webkit