Implemented PPB_Broker_Proxy.

ppapi/c/trusted/ppb_broker_trusted.h

 /* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #ifndef PPAPI_C_PPB_BROKER_TRUSTED_H_
 #define PPAPI_C_PPB_BROKER_TRUSTED_H_
 
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_resource.h"
 
+// DO NOT USE THIS INTERFACE

[brettw, 2011/04/15 16:09:25]

I'd probably just delete this. It's a trusted one so only internal users can use
it anyway.

[ddorwin, 2011/04/15 18:41:32]

Done.

+// TODO(ddorwin): Implement the required UX.
 #define PPB_BROKER_TRUSTED_INTERFACE "PPB_BrokerTrusted;0.1"
 
 /**
  * @file
  * This file defines the PPB_BrokerTrusted interface, which provides
  * access to a trusted broker with greater privileges than the plugin.
  */
 
 /**
  * @addtogroup Interfaces
  * @{
  */
 
 /**
  * The PPB_BrokerTrusted interface provides access to a trusted broker
  * with greater privileges than the plugin. The interface only supports
  * out-of-process plugins and is to be used by proxy implementations.  All
  * functions should be called from the main thread only.
+ *
+ * A PPB_BrokerTrusted resource represents a connection to the broker. Its
+ * lifetime controls the lifetime of the broker, regardless of whether the
+ * handle is closed. The handle should be closed before the resource is
+ * released.
  */
 struct PPB_BrokerTrusted {
   /**
    * Returns a trusted broker resource.
    */
   PP_Resource (*CreateTrusted)(PP_Instance instance);
 
   /**
    * Returns true if the resource is a trusted broker.
    */
   PP_Bool (*IsBrokerTrusted)(PP_Resource resource);
 
   /**
    * Connects to the trusted broker. It may have already
-   * been launched by another plugin instance.
+   * been launched by another instance.
+   * The plugin takes ownership of the handle once the callback has been called
+   * with a result of PP_OK. The plugin should immediately call GetHandle and
+   * begin managing it. If the result is not PP_OK, the browser still owns the
+   * handle.
+   *
    * Returns PP_ERROR_WOULD_BLOCK on success, and invokes
    * the |connect_callback| asynchronously to complete.
    * As this function should always be invoked from the main thread,
    * do not use the blocking variant of PP_CompletionCallback.
    * Returns PP_ERROR_FAILED if called from an in-process plugin.
    */
   int32_t (*Connect)(PP_Resource broker,
                      struct PP_CompletionCallback connect_callback);
 
   /**
    * Returns the handle to the pipe. Use once Connect has completed.
    * Returns PP_OK on success.
-   * Each plugin instance has its own pipe.
+   * Each instance of this interface has its own pipe.
+   * handle is only set when returning PP_OK.
    */
   int32_t (*GetHandle)(PP_Resource broker, int32_t* handle);
 };
 /**
  * @}
  */
 
 #endif  /* PPAPI_C_PPB_BROKER_TRUSTED_H_ */